Skip to content

Conversation

@Ni-g-3l
Copy link
Contributor

@Ni-g-3l Ni-g-3l commented Nov 5, 2024

Allow user to run multiple tests thanks wildcard

For example:

  • rez test testing_obj-1.0 command_as_* will run command_as_string_success and command_as_string_fail`
  • rez test testing_obj-1.0 command_as_* check_car_ideas will run command_as_string_success, command_as_string_fail' and check_car_idea`

@Ni-g-3l Ni-g-3l requested a review from a team as a code owner November 5, 2024 21:59
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@JeanChristopheMorinPerso
Copy link
Member

Hi @Ni-g-3l, thanks for creating this PR.

Before we can review and consider your changes, you will need to sign the CLA. See the comment above for details.

Let us know if you have questions.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added Blocked by CLA Waiting on CLA to be signed and removed Blocked by CLA Waiting on CLA to be signed labels Nov 6, 2024
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.33%. Comparing base (39c6ae6) to head (64ae7e3).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/cli/test.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   59.31%   59.33%   +0.02%     
==========================================
  Files         126      126              
  Lines       17219    17225       +6     
  Branches     3017     3017              
==========================================
+ Hits        10213    10221       +8     
+ Misses       6322     6320       -2     
  Partials      684      684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeanChristopheMorinPerso
Copy link
Member

Thanks, I triggered the CI.

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments that I think should be easy to address.

Thank you so much for adding tests! I love it.


return self.get_package_test_names(package, run_on=run_on)

def find_requested_test_names(self, requested_tests):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, could we maybe add a new parameter to get_test_names? I'm not sure why we need a different method when get_test_names could have the ability to do all the filtering for us.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to separate fetch tests from packages and filter them on regex in order keep available to fetch tests without any filter, but I could be wrong and this case won't appear the future. As you want I can make the fix I you want

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jan 26, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Add Wildcard support on rez test command Add wildcard support on rez test command Jan 26, 2025
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. We can always refine the methods later, now that we have a deprecation mechanism in place.

@maxnbk maxnbk merged commit 02f0132 into AcademySoftwareFoundation:main May 15, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants