-
Notifications
You must be signed in to change notification settings - Fork 357
Add wildcard support on rez test command #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Ni-g-3l, thanks for creating this PR. Before we can review and consider your changes, you will need to sign the CLA. See the comment above for details. Let us know if you have questions. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 59.31% 59.33% +0.02%
==========================================
Files 126 126
Lines 17219 17225 +6
Branches 3017 3017
==========================================
+ Hits 10213 10221 +8
+ Misses 6322 6320 -2
Partials 684 684 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, I triggered the CI. |
JeanChristopheMorinPerso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments that I think should be easy to address.
Thank you so much for adding tests! I love it.
|
|
||
| return self.get_package_test_names(package, run_on=run_on) | ||
|
|
||
| def find_requested_test_names(self, requested_tests): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, could we maybe add a new parameter to get_test_names? I'm not sure why we need a different method when get_test_names could have the ability to do all the filtering for us.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to separate fetch tests from packages and filter them on regex in order keep available to fetch tests without any filter, but I could be wrong and this case won't appear the future. As you want I can make the fix I you want
JeanChristopheMorinPerso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. We can always refine the methods later, now that we have a deprecation mechanism in place.
Signed-off-by: Nig3l <[email protected]>
Signed-off-by: Nig3l <[email protected]>
Signed-off-by: Nig3l <[email protected]>
Allow user to run multiple tests thanks wildcard
For example:
rez test testing_obj-1.0 command_as_*will runcommand_as_string_successand command_as_string_fail`rez test testing_obj-1.0 command_as_* check_car_ideaswill runcommand_as_string_success,command_as_string_fail' andcheck_car_idea`