Register plugin from entry points

[Ni-g-3l]

Hello

As suggest here I implemented the support of entrypoints in order to make the process of adding plugin to REZ easier.

Closes #1661

Feel free to add feedback !

Have a great day

[codecov]

Codecov Report

❌ Patch coverage is 68.51852% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.42%. Comparing base (2112930) to head (362de1a).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/rez/plugin_managers.py	68.51%	12 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   59.33%   59.42%   +0.08%     
==========================================
  Files         126      126              
  Lines       17225    17258      +33     
  Branches     3017     3022       +5     
==========================================
+ Hits        10221    10256      +35     
+ Misses       6320     6317       -3     
- Partials      684      685       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[JeanChristopheMorinPerso]

Thanks @Ni-g-3l for creating this PR. I left a couple of comments that will need to be addressed before we can consider merging it.

Also, if you have the time and want to, we should adjust our newly written plugins doc (https://rez.readthedocs.io/en/stable/plugins.html).

[Ni-g-3l]

Hello ! I fixed a big part of your comments, but I still not understand how you want resolve the plugin install with pip in tests

[JeanChristopheMorinPerso]

Thanks @Ni-g-3l . I left a comment to clarify what I mean about the tests.

[Ni-g-3l]

If you prefer this format of build system, we should update plugins doc by replacing setup.py part by a pyproject.toml.

[JeanChristopheMorinPerso]

Ok, sorry for the noise @Ni-g-3l. There are a couple of things I wanted which were easier to do myself than do the back and forth in a PR.

I also removed and re-added the vendored dependen.cies (and added the missing ones) and made sure they are compatible with python 3.7+.

I think the last thing will be to review the docs you wrote. I'll try to do that soon.

Thanks!

[Ni-g-3l]

Don't worry ! Happy to help ! I take a look at your commits and understand it ! I will do it the same way next time :)

Yes ! I will update doc according to your commits

[JeanChristopheMorinPerso]

@Ni-g-3l After testing this PR more, I came to the conclusion that it wasn't working as expected. I pushed new commits to correct this. There is now one entry point group per plugin type and plugin name is set to the entry point name instead of the module name.

[Ni-g-3l]

Wouldn't it be strange if the command name in the python file won't match with the command name displayed with rez -i ?

Moreover, won't it break the compatibility between plugins installed manually and ones installed with entry points ?

Thanks for testing the PR do not hesitate if I can help you to do something !

[JeanChristopheMorinPerso]

@Ni-g-3l The command name and the name in rez -i will be the same with my changes, unless I made a mistake...

[Ni-g-3l]

Oo sorry I missed one commit ! So it looks good to me.

[JeanChristopheMorinPerso]

FYI, I'm close to approving your PR and merging it.

The last remaining thing I think is the docs. You already edited them (thanks for that) but I'd like to improve them a little bit more. More particularly, I would like them to describe the 3 different methods of installing plugins (using the namespace package, REZ_PLUGINS_PATH and now the entry points. Each method should have its section describing how they work. The plugins page could be kept as a technical reference and we could move the "how to" into the user guide section.

What do you think?

[Ni-g-3l]

I think it's a good Idea ! But we have to care to keep a link between the old plugin page to the new one.

[JeanChristopheMorinPerso]

This section still needs some work. I didn't touch it.

[Ni-g-3l]

What are the sections that are need improvements ? Have you specific things in mind ?

[JeanChristopheMorinPerso]

@Ni-g-3l I took a stab at updating the docs. There is still one section of the guide that I think should be changed a little bit. Feel free to push changes to continue improving the docs.

[JeanChristopheMorinPerso]

@Ni-g-3l why did you close this PR?

[Ni-g-3l]

OMG ! I fucked my local git... so I removed and reclone it, I forgot that it will closed all PR from the fork, I will recreate this one... with the same name, so if you push your local branch to it we should get the modification back.

[Ni-g-3l]

I recreate it from backup here if you want : #1989

sorry for inconvenient...