Skip to content

Conversation

@michalfratczak
Copy link
Contributor

This allows to import rez module from paths with forward slashes. The following code printed "False" before the fix:

import sys
sys.path.append('C:/rez_test/Lib/site-packages')
from rez.system import system
print( 'is_production_rez_install', system.is_production_rez_install )

@michalfratczak michalfratczak requested a review from a team as a code owner December 23, 2024 16:21
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: michalfratczak / name: Michal (10f3744)
  • ✅ login: JeanChristopheMorinPerso / name: Jean-Christophe Morin (9bea979)

@JeanChristopheMorinPerso
Copy link
Member

@michalfratczak Can you fix the DCO please? You can follow the instructions at https://github.com/AcademySoftwareFoundation/rez/pull/1899/checks?check_run_id=36186947320.

@codecov
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (21a5735) to head (9bea979).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1899   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files         126      126           
  Lines       17217    17218    +1     
  Branches     3017     3017           
=======================================
+ Hits        10207    10208    +1     
  Misses       6325     6325           
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jan 26, 2025
michalfratczak and others added 2 commits January 26, 2025 18:40
…lash paths under windows.

This allows to import rez module from paths with forward slashes. The following code printed "False" before the fix:

import sys
sys.path.append('C:/rez_test/Lib/site-packages')
from rez.system import system
print( 'is_production_rez_install', system.is_production_rez_install )

Signed-off-by: Michal Fratczak <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Michal Fratczak <[email protected]>
@michalfratczak
Copy link
Contributor Author

@JeanChristopheMorinPerso DCO fixed.

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 233b82c into AcademySoftwareFoundation:main Jan 26, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants