Add ability to change the executable_fullpath setting for the gitbash shell plugin#1938
Merged
maxnbk merged 3 commits intoAcademySoftwareFoundation:mainfrom May 15, 2025
Conversation
vanridal
force-pushed
the
1937-Gitbash-shells-cant-change-executable_fullpath-in-rezconfig.py-settings
branch
from
5f4dec7 to
9bcc72c
Compare
Contributor
Author
vanridal
force-pushed
the
1937-Gitbash-shells-cant-change-executable_fullpath-in-rezconfig.py-settings
branch
from
294b165 to
7ef0088
Compare
Contributor
Author
|
Added test for config override of shell plugin executable |
maxnbk
approved these changes
Apr 4, 2025
Contributor
maxnbk
left a comment
maxnbk
left a comment
There was a problem hiding this comment.
Very nice! Simple change and a test to cover. I've put this into the "Next" milestone, and I'll see if anything else makes sense to merge/release alongside as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
+ Coverage 59.28% 59.31% +0.02%
==========================================
Files 126 126
Lines 17219 17219
Branches 3017 3017
==========================================
+ Hits 10209 10213 +4
+ Misses 6325 6322 -3
+ Partials 685 684 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxnbk
reviewed
Apr 4, 2025
JeanChristopheMorinPerso
changed the title
JeanChristopheMorinPerso
approved these changes
May 4, 2025
Member
JeanChristopheMorinPerso
left a comment
JeanChristopheMorinPerso
left a comment
There was a problem hiding this comment.
Thank you! I love the addition of the test!
so the inherited method will use GitBash.name(), via cls.name() to access config settings in rez.shells.Shell.find_executable() Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
maxnbk
force-pushed
the
1937-Gitbash-shells-cant-change-executable_fullpath-in-rezconfig.py-settings
branch
from
c66440e to
b546c8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed to use super() methods so the inherited method will use GitBash.name(), via cls.name() to access config settings in rez.shells.Shell.find_executable()
Fixes #1937