Fix type of PackageOrderList in ResolvedContext.from_dict #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: george.ridal <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
+ Coverage 60.02% 60.04% +0.02%
==========================================
Files 163 163
Lines 20118 20118
Branches 3506 3506
==========================================
+ Hits 12075 12080 +5
+ Misses 7223 7220 -3
+ Partials 820 818 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vanridal
force-pushed
the
#1984-Package-orderes-are-wrong-type-when-context-generate-from-.rxt
branch
from
b73ca64 to
ecedd27
Compare
Signed-off-by: george.ridal <[email protected]>
vanridal
force-pushed
the
#1984-Package-orderes-are-wrong-type-when-context-generate-from-.rxt
branch
from
ecedd27 to
84a3ce2
Compare
…es-are-wrong-type-when-context-generate-from-.rxt
…es-are-wrong-type-when-context-generate-from-.rxt
JeanChristopheMorinPerso
changed the title
JeanChristopheMorinPerso
changed the title
JeanChristopheMorinPerso
approved these changes
Jun 21, 2025
Member
JeanChristopheMorinPerso
left a comment
JeanChristopheMorinPerso
left a comment
There was a problem hiding this comment.
Thank you @vanridal!
JeanChristopheMorinPerso
merged commit d508f0b
into
AcademySoftwareFoundation:main
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1984
set to expected type PackageOrderList