Fix Qodana issues

[piotrzajac]

Summary by CodeRabbit

• Refactor

  • Improved code maintainability by reusing predicate logic in assertion methods.
  • Updated namespace imports for consistency.
  • Removed certain method attributes for streamlined code.

• Chores

  • Enhanced workflow to optionally upload scan results as artifacts during manual runs.
  • Enabled automatic posting of scan comments on pull requests.

[coderabbitai]

Walkthrough

This change refactors the FixtureAssertionExtensions class by replacing inline lambda expressions for type-checking with private generic helper methods. It also removes the [AssertionMethod] attributes from all internal static methods and updates the namespace import from JetBrains.Annotations to global::AutoFixture.Kernel. The overall control flow and error handling remain unchanged, as the modifications are limited to improving predicate reuse and making minor namespace adjustments. Additionally, the GitHub Actions workflow for Qodana scanning was updated to support conditional artifact uploads on manual dispatch and enhanced permissions for pull request commenting.

Changes

File(s)	Change Summary
src/Objectivity.AutoFixture.XUnit2.Core.Tests/FixtureAssertionExtensions.cs	Replaced inline type-checking lambdas with private generic helper methods; removed [AssertionMethod] attributes; replaced JetBrains.Annotations using directive with global::AutoFixture.Kernel; introduced local function for predicate filtering; no control flow changes.
.github/workflows/qodana.yml	Added optional input upload-result-as-artifact for manual workflow dispatch; expanded job permissions to include pull-requests: write; configured Qodana scan step to conditionally upload results as artifacts and post PR comments using GitHub token; set environment variable for Qodana endpoint.

Possibly related PRs

• Fix/apply qodana suggestions #251: Adds [AssertionMethod] attributes to the same methods in FixtureAssertionExtensions.cs, which is directly related but opposite in intent regarding these attributes.

Poem

A rabbit hopped through lines of code,
Refactoring predicates as it strode.
Lambdas replaced, helpers in tow,
Attributes gone where they used to glow.
With namespaces neat and logic the same,
The code is now tidy—oh, what a game!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fada27f and 8709b56.

📒 Files selected for processing (1)

• .github/workflows/qodana.yml (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/qodana.yml

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: build-test-pack (AutoNSubstitute) / run
• GitHub Check: build-test-pack (AutoMoq) / run
• GitHub Check: build-test-pack (Core) / run
• GitHub Check: build-test-pack (AutoFakeItEasy) / run
• GitHub Check: scan
• GitHub Check: test
• GitHub Check: scan (csharp)
• GitHub Check: scan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e1c9d78) to head (8709b56).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines          424       424           
  Branches        55        55           
=========================================
  Hits           424       424           

Flag	Coverage Δ
unittests	99.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dbe0df and 3845c9b.

📒 Files selected for processing (1)

• .github/workflows/qodana.yml (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: build-test-pack (AutoNSubstitute) / run
• GitHub Check: build-test-pack (AutoFakeItEasy) / run
• GitHub Check: build-test-pack (Core) / run
• GitHub Check: build-test-pack (AutoMoq) / run
• GitHub Check: test
• GitHub Check: scan
• GitHub Check: scan (csharp)

🔇 Additional comments (3)

.github/workflows/qodana.yml (3)

18-22: New input parameter for manual artifact uploads looks correct
The workflow_dispatch inputs are defined properly to let users opt into uploading Qodana results as artifacts. Inputs in GitHub Actions are always strings, so defaulting to 'false' is the right approach.

---

35-35: Add pull-requests write permission
Granting pull-requests: write is necessary for the action to post comments on PRs. This follows the principle of least privilege, as only PR-related write access is granted.

---

62-63: Verify scan comment and token configuration
The post-pr-comment: true setting and passing github-token: ${{ github.token }} correctly enable the action to leave PR comments using the built-in token.