Skip to content

Use [NoEnumeration] to prevent the false positive #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotrzajac merged 3 commits into from
Apr 24, 2025
Merged

Use [NoEnumeration] to prevent the false positive #254

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1a975c
Mark "possible multiple enumeration" issue with [NoEnumerationAttrib…
piotrzajac Apr 24, 2025
f095f36
Add blank lines to improve readability in using section
piotrzajac Apr 24, 2025
42ab562
Decorate the EnumerableExtensions.ToTypedArray method instead.
piotrzajac Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Objectivity.AutoFixture.XUnit2.Core/Common/EnumerableExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
using System.Linq;
using System.Reflection;

using JetBrains.Annotations;

internal static class EnumerableExtensions
{
private static readonly MethodInfo BuildTypedArrayMethodInfo =
Expand Down Expand Up @@ -44,7 +46,7 @@ public static bool TryGetEnumerableSingleTypeArgument(this Type type, out Type a
return false;
}

public static object ToTypedArray(this IEnumerable items, Type itemType)
public static object ToTypedArray([NoEnumeration] this IEnumerable items, Type itemType)
{
var method = BuildTypedArrayMethodInfo.MakeGenericMethod(itemType.NotNull(nameof(itemType)));
return method.Invoke(null, new object[] { items.NotNull(nameof(items)) });
Expand Down
Loading