Fail on publishing report to Qodana cloud #256
Conversation
WalkthroughThe GitHub Actions workflow Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/qodana.yml (1)
67-67:Details
❓ Verification inconclusive
Validate
--log-level=debugsupport and guard against sensitive output
The added--log-level=debugwill emit much more detail—and could inadvertently surface secrets likeQODANA_TOKEN. Please confirm that:
- The JetBrains Qodana CLI/Action actually accepts
--log-level=debugin this form.- Debug-level logs still honor GitHub’s secret-masking so tokens aren’t leaked.
You can verify flag support by inspecting the CLI help or Action source, for example:
Consider gating debug logging behind a workflow input or conditional so it’s only enabled when you explicitly need deeper diagnostics.
🏁 Script executed:
qodana scan --help | grep log-levelLength of output: 134
Validate debug log-level support and guard against secret exposure
The sandbox couldn’t runqodana scan, so please manually verify:
- Flag support: Confirm the Qodana CLI/Action accepts
--log-level=debug(e.g. runqodana scan --helplocally and look for “log-level”).- Secret‐masking: Ensure debug-level logs still honor GitHub’s secret-masking so
QODANA_TOKEN(and other secrets) aren’t leaked.Consider gating
--log-level=debugbehind a workflow input or conditional so it’s only enabled when deeper diagnostics are explicitly needed.
Qodana Community for .NETAnalyzed project: It seems all right 👌 No new problems were found according to the checks applied View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 424 424
Branches 55 55
=========================================
Hits 424 424
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/qodana.yml (1)
75-75: Clarify expression precedence for--log-level
The mix of&&and||without parentheses relies on operator precedence. To avoid unexpected fallbacks, consider grouping with parentheses:--log-level,${{ (github.event_name == 'workflow_dispatch' && inputs.log-level) || 'error' }},This ensures the fallback to
'error'only happens wheninputs.log-levelis unset.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/qodana.yml(2 hunks)src/qodana.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/qodana.yaml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/qodana.yml
[warning] 30-30: wrong indentation: expected 8 but found 10
(indentation)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build-test-pack (AutoFakeItEasy) / run
- GitHub Check: build-test-pack (AutoNSubstitute) / run
- GitHub Check: build-test-pack (AutoMoq) / run
- GitHub Check: build-test-pack (Core) / run
- GitHub Check: scan
- GitHub Check: scan (csharp)
- GitHub Check: test
🔇 Additional comments (2)
.github/workflows/qodana.yml (2)
24-32: Newlog-levelinput: indentation and YAMLlint warning
The addition of thelog-levelchoice input is correct and aligns with existinginputs(same indent asupload-result-as-artifact). Theoptionslist is indented two spaces deeper, which is standard for YAML sequences under a mapping key—even though YAMLlint flags line 30 for indentation; this appears to be a false positive.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 30-30: wrong indentation: expected 8 but found 10
(indentation)
71-71: Conditionalupload-resultonly on manual dispatch
You’ve restrictedupload-result: ${{ github.event_name == 'workflow_dispatch' && inputs.upload-result-as-artifact == true }}, so Qodana results are only sent to the cloud when manually triggered andupload-result-as-artifactistrue. Verify that this matches the PR objective to fail on publishing to Qodana cloud—if you intend to always fail on publish errors for all triggers, you may need to adjust the condition or expose a separate input.
Summary by CodeRabbit