Skip to content

Remove AutoFixture.Xunit2 dependency from CustomizeAttributeComparer #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotrzajac merged 1 commit into from
Apr 28, 2025
Merged

Remove AutoFixture.Xunit2 dependency from CustomizeAttributeComparer #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Objectivity.AutoFixture.XUnit2.Core.Tests/Comparers/CustomizeAttributeComparerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
[Trait("Category", "Comparers")]
public class CustomizeAttributeComparerTests
{
private static readonly CustomizeAttributeComparer Comparer = new();
private static readonly CustomizeAttributeComparer<FrozenAttribute> Comparer = new();
private static readonly CustomizeWithAttribute CustomizeAttribute = new(typeof(DoNotThrowOnRecursionCustomization));
private static readonly FrozenAttribute FrozenAttribute = new();

Expand Down
2 changes: 1 addition & 1 deletion src/Objectivity.AutoFixture.XUnit2.Core/Attributes/AutoDataAdapterAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ private void CustomizeFixture(ParameterInfo p)
{
var customizeAttributes = p.GetCustomAttributes()
.OfType<IParameterCustomizationSource>()
.OrderBy(x => x, new CustomizeAttributeComparer());
.OrderBy(x => x, new CustomizeAttributeComparer<FrozenAttribute>());

foreach (var ca in customizeAttributes)
{
Expand Down
11 changes: 4 additions & 7 deletions src/Objectivity.AutoFixture.XUnit2.Core/Comparers/CustomizeAttributeComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,14 @@
using System.Collections.Generic;

using global::AutoFixture;
using global::AutoFixture.Xunit2;

/// <summary>
/// Direct copy from the AutoFixture source code as the original class is internal.
/// </summary>
internal class CustomizeAttributeComparer : Comparer<IParameterCustomizationSource>
internal class CustomizeAttributeComparer<T> : Comparer<IParameterCustomizationSource>
where T : IParameterCustomizationSource
{
public override int Compare(IParameterCustomizationSource x, IParameterCustomizationSource y)
{
var isXFrozen = x is FrozenAttribute;
var isYFrozen = y is FrozenAttribute;
var isXFrozen = x is T;
var isYFrozen = y is T;

if (isXFrozen && !isYFrozen)
{
Expand Down
Loading