Skip to content

Update shortcuts.ts #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devslovecoffee wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Update shortcuts.ts #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helpers/shortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const tooltips: Record<string, string> = {
};

function getTooltip(key: string) {
return tooltips[key];
return ":" + tooltips[key];
Copy link
Copy Markdown

@callstackai-action callstackai-action bot Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 Bug
The getTooltip function does not check if the key exists in the tooltips object before accessing it. This could lead to returning ':undefined' if the key is not found, potentially causing unexpected behavior when the tooltip is used.

Suggested change
return ":" + tooltips[key];
return tooltips[key] ? ':' + tooltips[key] : undefined;

}
function transformKeys(keys: string[]) {
return keys.map((key: string) => {
Expand Down