Responsive heart #20
Merged
Responsive heart #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK if both dimensions are bounded with max-*, the browser won't try to fill that proactively. Confirmed in FF/Chrome/Safari.
Contributor
Author
|
@mattmassicotte does this fit your rough idea? |
Contributor
|
Fantastic thank you! |
mattmassicotte
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With text in #7 I noticed some sizing oddities.
This restores responsive heart graphics sizes (AFAIK one dimension needs to be set directly, not merely bounded with
max-).Also makes the gap responsive.
Both react to the title font now so that they should remain in proportion