Skip to content

CUR-4454: Preview-Share: P/P/A still appears on share link page when turning the "Disable Sharing" button with "Library Preferences: ALL" option on Project #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CUR-4454: Preview-Share: P/P/A still appears on share link page when turning the "Disable Sharing" button with "Library Preferences: ALL" option on Project #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/Http/Controllers/Api/V1/ActivityController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,8 +729,7 @@ public function getH5pResourceSettingsOpen(Activity $activity)
*/
public function getH5pResourceSettingsShared(Activity $activity)
{
// 3 is for indexing approved - see Project Model @indexing property
if ($activity->shared || ($activity->playlist->project->indexing === (int)config('constants.indexing-approved'))) {
if ($activity->shared) {
$h5p = App::make('LaravelH5p');
$core = $h5p::$core;
$settings = $h5p::get_editor($content = null, 'preview');
Expand Down
3 changes: 1 addition & 2 deletions app/Http/Controllers/Api/V1/IndependentActivityController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,8 +792,7 @@ public function getH5pResourceSettings(IndependentActivity $independent_activity
*/
public function getH5pResourceSettingsShared(IndependentActivity $independent_activity)
{
// 3 is for indexing approved - see IndependentActivity Model @indexing property
if ($independent_activity->shared || ($independent_activity->indexing === (int)config('constants.indexing-approved'))) {
if ($independent_activity->shared) {
$h5p = App::make('LaravelH5p');
$core = $h5p::$core;
$settings = $h5p::get_editor();
Expand Down