Force prompt option should override non-interactive option. #3616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
changed the title
mitchell-as
commented
Dec 17, 2024
| } | ||
|
|
||
| if !p.isInteractive { | ||
| } else if !p.isInteractive { |
Collaborator
Author
There was a problem hiding this comment.
The bug here is that we were checking for force and setting nonInteractiveResponse but if !p.isInteractive is also true (it's usually not), then the nonInteractiveResponse we just set would be overwritten with a different value. Oops.
Same applies to the other changes in this PR.
tjsanterre
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also assert installing as admin prompt happens on Windows.