Return a commit even if there's a polling error.

[mitchell-as]

DX-3205 Nightly failure: CycloneDX and SPDX SBOM imports do not create commits

Recent Platform changes have resulted in every stageCommit call responding with "build planning".

state import does not care if the plan ultimately fails due to requirements not being found. It should still make the commit.

[mitchell-as]

We do the same thing earlier in this function:

cli/pkg/platform/model/buildplanner/commit.go

Lines 65 to 67 in 2d271e1

	if response.IsErrorResponse(resp.Build.Type) {
	return &Commit{resp, nil, nil}, response.ProcessBuildError(resp.Build, "Could not process error response from stage commit")
	}

It's up to the caller to handle error conditions, and state import does something with the returned commit, even if there's an error:

cli/internal/runners/packages/import.go

Lines 129 to 141 in 2d271e1

	stagedCommit, err := bp.StageCommit(buildplanner.StageCommitParams{
	Owner: proj.Owner(),
	Project: proj.Name(),
	ParentCommit: localCommitId.String(),
	Description: msg,
	Script: bs,
	})
	// Always update the local commit ID even if the commit fails to build
	if stagedCommit != nil && stagedCommit.Commit != nil && stagedCommit.Commit.CommitID != "" {
	if err := localcommit.Set(proj.Dir(), stagedCommit.CommitID.String()); err != nil {
	return locale.WrapError(err, "err_package_update_commit_id")
	}
	}

Other callers just error if err is not nil. The point is, it's okay to return the commit returned by StageCommit, even if there was ultimately an error (the commit was created after all; it just doesn't build).