Add "arch" param to install script's state-update URLs. #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is no longer needed. The bootstrap was all that was needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a chicken-and-egg problem. State Tool needs itself to build on CI, but no State Tool builds for ARM have been released (via CI). I've bootstrapped an ARM build that can be installed, but the install scripts cannot find it yet since the existing install script assumes the arch is amd64.
This PR only changes the install script to allow for detecting and passing the architecture to the state-update service in order to retrieve ARM builds.
Once this PR is resolved, #3632 can start building on CI.