Added integration test for state checkout --portable.
#3647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-3227
branch
from
f025fe7 to
d4b5cdd
Compare
mitchell-as
force-pushed
the
mitchell/dx-3227
branch
from
d4b5cdd to
67cc9d1
Compare
Naatan
approved these changes
Feb 18, 2025
Comment on lines
+421
to
+428
| files, err := fileutils.ListDir(targetDir, true) | ||
| suite.Require().NoError(err) | ||
| for _, file := range files { | ||
| path := filepath.Join(targetDir, file.Name()) | ||
| resolvedPath, err := fileutils.ResolvePath(path) | ||
| suite.Require().NoError(err) | ||
| suite.Assert().NotContains(resolvedPath, "depot", "runtime file '%s' should not be linked to the depot", file.Name()) | ||
| } |
Contributor
There was a problem hiding this comment.
If this works, great! But we could theoretically still have symlinks originating from the artifact themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.