Skip to content

After dynamically evaluating a build plan, staging a commit needs to use the latest timestamp. #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 1 commit into from
Sep 23, 2025
Merged

After dynamically evaluating a build plan, staging a commit needs to use the latest timestamp. #3749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/runbits/reqop_runbit/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ func UpdateAndReload(prime primeable, script *buildscript.BuildScript, oldCommit
if err := script.SetDynamic(false); err != nil {
return errs.Wrap(err, "Setting dynamic failed")
}
// StageCommitAndPoll needs to be called with atTime=now, not the previous script's atTime.
latest, err := model.FetchLatestRevisionTimeStamp(prime.Auth())
if err != nil {
return errs.Wrap(err, "Failed to fetch latest timestamp")
}
script.SetAtTime(latest, true)
}

commitParams := buildplanner.StageCommitParams{
Expand Down
Loading