feat(sync): gracefully handle SIGTERMs

[0xbrayo]

#502

---

Important

Adds graceful SIGTERM handling to aw-sync daemon using ctrlc crate for clean shutdown.

• Behavior:
  • Adds graceful shutdown handling for SIGTERM in daemon() in aw-sync/src/main.rs using ctrlc crate.
  • On receiving SIGTERM, the daemon loop breaks, allowing for clean shutdown.
• Dependencies:
  • Adds ctrlc crate to aw-sync/Cargo.toml and Cargo.lock for signal handling.
  • Updates colored and fern versions in Cargo.lock.
• Misc:
  • Updates Cargo.lock version to 4.

^{This description was created by for 630f0df. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 5e86d5b in 1 minute and 52 seconds

More details

• Looked at 150 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 11 drafted comments based on config settings.

1. aw-sync/src/main.rs:115

• Draft comment:
  Consider trimming whitespace in parse_list so that comma-separated inputs like "host1, host2" do not yield strings with extra spaces.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. aw-sync/src/main.rs:144

• Draft comment:
  Comment discrepancy: the comment states the default subcommand is Sync, but the code defaults to Daemon. Please update the comment to match the implementation.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. aw-sync/src/main.rs:179

• Draft comment:
  When validating the sync_db path, the check using starts_with might be affected by symlinks or path normalization. Consider canonicalizing paths to ensure robust verification.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. aw-sync/src/main.rs:220

• Draft comment:
  In the daemon loop, errors during a sync cycle cause an immediate return. If some errors are transient, consider logging and continuing rather than terminating the daemon.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. aw-sync/src/main.rs:128

• Draft comment:
  Use .into() for error conversion in Err("Sync dir must be absolute")?.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. aw-sync/src/main.rs:182

• Draft comment:
  Wrap error message with .into() in Err("Sync db path must be absolute")?.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. aw-sync/src/main.rs:185

• Draft comment:
  Wrap error message with .into() in Err("Sync db path must be in sync directory")?.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. aw-sync/src/main.rs:115

• Draft comment:
  Consider trimming whitespace in parse_list for better input handling.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

9. aw-sync/src/main.rs:144

• Draft comment:
  Comment says default subcommand is Sync but defaults to Daemon; update comment or default value.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. aw-sync/src/main.rs:10

• Draft comment:
  Remove unnecessary extern crate declarations for edition 2021.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

11. aw-sync/src/main.rs:205

• Draft comment:
  Typo: The comment currently reads '...give it some wiggleroom.' Consider changing 'wiggleroom' to 'wiggle room' for clarity.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_qDj5Gz81m3qQp2xO

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[0xbrayo]

@ellipsis-dev review

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 630f0df in 1 minute and 5 seconds

More details

• Looked at 166 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 8 drafted comments based on config settings.

1. aw-sync/src/main.rs:1

• Draft comment:
  TODO list: Consider updating TODO comments to reflect that start date now exists in SyncAdvanced command.
• Reason this comment was not posted:
  Confidence changes required: 30% <= threshold 50%
  None

2. aw-sync/src/main.rs:137

• Draft comment:
  Consider simplifying port extraction. Instead of mapping port to Ok(a) then unwrapping, use a more straightforward pattern.
• Reason this comment was not posted:
  Confidence changes required: 40% <= threshold 50%
  None

3. aw-sync/src/main.rs:180

• Draft comment:
  When checking the sync_db path, consider canonicalizing both paths to mitigate symlink issues.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

4. aw-sync/src/main.rs:113

• Draft comment:
  Consider trimming whitespace when splitting the list in parse_list.
• Reason this comment was not posted:
  Confidence changes required: 40% <= threshold 50%
  None

5. aw-sync/src/main.rs:10

• Draft comment:
  Remove redundant extern crate declarations (not needed in 2021 edition).
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. aw-sync/src/main.rs:142

• Draft comment:
  The comment states the default subcommand is Sync, yet unwrap_or(Commands::Daemon {}) defaults to Daemon. Clarify intended behavior.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. aw-sync/src/main.rs:113

• Draft comment:
  Consider trimming whitespace in parse_list to avoid issues with spaces in comma‐separated inputs.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. aw-sync/src/main.rs:127

• Draft comment:
  Consider using more descriptive error types (or wrapping errors) instead of bare string errors for invalid sync directory or db paths.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_9IrljRwfrkCezRmC

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ErikBjare]

Nice, thanks!