build(deps): update dirs to version 6#545
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Nov 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to b582baa in 1 minute and 21 seconds. Click for details.
- Reviewed
311lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw-client-rust/Cargo.toml:20
- Draft comment:
Consider aligning the version string for the 'dirs' dependency for consistency (e.g. use '6.0.0' as in other modules). - Reason this comment was not posted:
Comment looked like it was already resolved.
2. aw-client-rust/Cargo.toml:27
- Draft comment:
Avoid using the wildcard '*' for 'tokio-test'; consider pinning it to a specific version range to prevent unexpected breaks. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. aw-sync/Cargo.toml:25
- Draft comment:
Verify if the 'gethostname' version should match across modules—'aw-sync' uses '0.4.3' while 'aw-client-rust' uses '0.4'. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_CIkaZqlBLkvdKOqJ
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 70.81% 69.66% -1.16%
==========================================
Files 51 54 +3
Lines 2916 3145 +229
==========================================
+ Hits 2065 2191 +126
- Misses 851 954 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
dirsdependency to the latest version, 6.0.0.The SemVer-breaking change in
dirs6 is just thatdirs-sysis updated to 0.5, which, in turn, is just due to updating some platform-specific dependencies. There are therefore no API changes we need to worry about here.Important
Update
dirsdependency to version 6.0.0 inaw-client-rustandaw-syncprojects, with no API changes required.dirsto version6.0.0inaw-client-rust/Cargo.tomlandaw-sync/Cargo.toml.Cargo.lockto reflectdirsversion6.0.0anddirs-sysversion0.5.0.This description was created by
for b582baa. You can customize this summary. It will automatically update as commits are pushed.