fix: make modules in ~/aw-modules have top priority

[0xbrayo]

Important

Prioritize ~/aw-modules in path discovery for Windows and macOS in get_discovery_paths() in dirs.rs.

• Behavior:
  • Prioritize ~/aw-modules in get_discovery_paths() in dirs.rs for Windows and macOS.
  • Reorder path insertion to check aw-modules before other paths.
• Platforms:
  • Affects path discovery on Windows and macOS only.

^{This description was created by for af281b8. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to af281b8 in 49 seconds. Click for details.

• Reviewed 36 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. src-tauri/src/dirs.rs:144

• Draft comment:
  Windows: The new ordering adds the 'aw-modules' path after the AppData path. Verify that later entries are prioritized as intended (i.e. that 'aw-modules' has top priority).
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify the behavior of the code change, which violates the rule against asking for confirmation or verification of intended behavior. It does not provide a specific suggestion or point out a clear issue with the code.

2. src-tauri/src/dirs.rs:165

• Draft comment:
  macOS: The 'aw-modules' directory is now appended after the application bundle paths. Confirm that this ordering yields the desired top-priority behavior for local modules.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm the behavior of the ordering of directories, which violates the rule against asking for confirmation of intention or behavior. It does not provide a specific suggestion or point out a clear issue.

Workflow ID: wflow_VHqr0wH6ggMluD0L

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ErikBjare]

Is this good defaults? Seems kinda iffy to me, should maybe require more explicitness to override the built-ins.

[0xbrayo]

This relies on the order of entries on the config file, later entries superseding the one's before if there's a name collision. Maybe a comment on behavior in the config file might make it more explicit. Or perhaps a overrides entry, with name, path tuples?

[[override]]
{ name="aw-notify", path"=~/aw-modules/aw-notify"},

[0xbrayo]

@ErikBjare how do you think it should be implemented?

[ErikBjare]

Sorry for just dropping my 2 cents here without explanation. I'm not sure what the best way is, I think you have better context than me.

[0xbrayo]

it's all good 👍, forgot I made the PR from the master branch, will recreate it a feature branch, your input is always welcome❤️