Skip to content

Conversation

@0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Jan 7, 2026

Has no real effect on functionality, I probably did it this way as assurance of correctness?


Important

Remove redundant cvar.notify_all() calls in lib.rs and update .pre-commit-config.yaml to exclude a directory from a hook.

  • Code Simplification:
    • Remove redundant cvar.notify_all() calls in init_app_handle() and init_tray_id() in lib.rs.
  • Pre-commit Configuration:
    • Exclude ^src-tauri/gen/ from end-of-file-fixer hook in .pre-commit-config.yaml.

This description was created by Ellipsis for c882be2. You can customize this summary. It will automatically update as commits are pushed.

@0xbrayo 0xbrayo marked this pull request as ready for review January 15, 2026 13:25
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c882be2 in 1 minute and 47 seconds. Click for details.
  • Reviewed 82 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .pre-commit-config.yaml:30
  • Draft comment:
    Exclude rule for generated code looks good.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. src-tauri/src/dirs.rs:143
  • Draft comment:
    Windows discovery paths now include the AppData path before 'aw-modules'. Confirm that the ordering (and addition) is intentional.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. src-tauri/src/dirs.rs:154
  • Draft comment:
    The macOS block now pushes the aw‑modules path after the built‑in paths. Ensure this reordering meets the intended discovery order.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the reordering of paths meets the intended discovery order. This falls under asking the author to confirm their intention, which is against the rules.
4. src-tauri/src/lib.rs:60
  • Draft comment:
    Removed notify_all in init_app_handle – verify that no thread is waiting on HANDLE_CONDVAR that would require an explicit wake-up.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that no thread is waiting on a condition variable that would require an explicit wake-up. This falls under asking the author to double-check or ensure behavior, which is against the rules.
5. src-tauri/src/lib.rs:73
  • Draft comment:
    Removed notify_all in init_tray_id – ensure that get_tray_id (which waits on TRAY_CONDVAR) won’t block if called concurrently.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that a specific function won't block due to a change. This is a request for confirmation of behavior, which violates the rules.

Workflow ID: wflow_qMSppI9hdg0ILzio

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@0xbrayo 0xbrayo merged commit 0947882 into ActivityWatch:master Jan 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant