Skip to content

Conversation

@0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Jan 16, 2026

Important

Switch aw-notify notification parsing to JSON Lines format in manager.rs.

  • Behavior:
    • start_notify_module_thread in manager.rs now parses notifications as JSON Lines instead of using a custom format with dashes.
    • Extracts title and message from JSON notifications and formats them as "title\nmessage".
    • Logs an error if JSON notification is missing title or message fields.
    • Falls back to logging non-JSON lines as potential info logs or old format.

This description was created by Ellipsis for 62c9cfb. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 62c9cfb in 52 seconds. Click for details.
  • Reviewed 63 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/manager.rs:719
  • Draft comment:
    Consider checking for empty lines (e.g. using if line_content.trim().is_empty() { continue; }) before attempting to parse as JSON. This can reduce unnecessary parse attempts and debug log noise.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. src-tauri/src/manager.rs:742
  • Draft comment:
    Consider logging detailed serde_json errors when JSON parsing fails (instead of only logging non-JSON output) to aid in debugging malformed notifications.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_jnTTMb5u0xiBPUAA

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@0xbrayo 0xbrayo merged commit feb2658 into ActivityWatch:master Jan 16, 2026
6 checks passed
@ErikBjare
Copy link
Member

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants