Skip to content

Conversation

@ellipsis-dev
Copy link

@ellipsis-dev ellipsis-dev bot commented Jul 1, 2024

This change addresses review comments left by @ErikBjare on PR #33: feat: add toml config and arg parsing for poll time

⚠️ We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Summary:

Refactor main function in src/aw_watcher_input/main.py to use click for CLI handling and fix poll_time references.

Key points:

  • Refactor src/aw_watcher_input/main.py to use click for CLI handling.
  • Remove args parameter from main function.
  • Introduce --testing flag in main function.
  • Fix variable references for poll_time in main function.

You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.


Something look wrong?: If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot requested a review from ErikBjare July 1, 2024 11:50
@ErikBjare
Copy link
Member

Bad formatting etc, not a good job.

@ErikBjare ErikBjare closed this Jul 1, 2024

@click.command()
@click.option("--testing", is_flag=True)
@click.option("--testing", is_flag=True) testing: bool

Check failure

Code scanning / CodeQL

Syntax error

Syntax Error (in Python 3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants