fix: add Helium to browser list#744
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7ca67ac in 5 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_gMRCLKVW512Wewmr
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile OverviewGreptile SummaryThis PR updates Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as aw-webui
participant AW as ActivityWatch server
UI->>AW: query available buckets (aw-client)
AW-->>UI: list of bucketIds
UI->>UI: browsersWithBuckets() maps known browsers to bucketIds
UI->>AW: canonicalEvents() / fullDesktopQuery() includes browserEvents()
AW-->>UI: window events + browser_events
UI->>UI: filter window events by browser_appnames[helium]
UI-->>UI: Helium window activity counted as browser activity
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 26.20% 26.20%
=======================================
Files 29 29
Lines 1706 1706
Branches 311 311
=======================================
Hits 447 447
Misses 1195 1195
Partials 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @deancureton! Thanks for adding Helium support. Note: PR #752 (merged yesterday) refactored browser detection to use regex-based matching alongside exact app names. Your PR now has merge conflicts with master since the The simplest path forward is to add Helium to the new regex system. I can include it in a follow-up, or if you'd like to update this PR, the changes needed are:
Let me know if you'd like me to handle this! |
Add Helium (https://helium.computer) to browser detection: - Exact match for bundle ID: net.imput.helium - Regex pattern: (?i)^helium (covers Helium, helium.exe, etc.) - Regression test with all known app name variants Supersedes ActivityWatch#744 which was against the pre-regex format.
|
@TimeToBuildBob thanks, just handled it! |
|
Thanks! |
Just adding Helium (https://helium.computer, https://github.com/imputnet/helium) to the browser list. It's Chromium-based so this is the only change needed to get it working well in the web UI. Thanks!!
Important
Add Helium to
browser_appnamesinsrc/queries.tsto support Helium browser events.browser_appnamesinsrc/queries.tsto support Helium browser events.This description was created by
for 7ca67ac. You can customize this summary. It will automatically update as commits are pushed.