Skip to content

fix: pass bucket ID correctly for event editing in timeline views #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Feb 22, 2026
Merged

fix: pass bucket ID correctly for event editing in timeline views #765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/visualizations/VisTimeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,18 @@ export default {
} else if (properties.items.length == 1) {
const event = this.chartData[properties.items[0]].event;
const groupId = this.items[properties.items[0]].group;
const bucketId = _.find(this.groups, g => g.id == groupId).content;
// Use group.id (not group.content) — content is '' when showRowLabels=false
const bucketId = _.find(this.groups, g => g.id == groupId).id;

// Skip editing if event has no ID (e.g. merged query results) or bucket is a placeholder
if (!event.id || !bucketId || bucketId === 'events' || bucketId === 'search') {
console.log(
'Event has no ID or bucket is a placeholder, skipping editor',
event,
bucketId
);
return;
}

// We retrieve the full event to ensure if's not cut-off by the query range
// See: https://github.com/ActivityWatch/aw-webui/pull/320#issuecomment-1056921587
Expand Down
Loading