Sigrid Benezra - Edges - Inspiration Board#20
Open
sdbenezra wants to merge 5 commits intoAda-C10:masterfrom
Open
Sigrid Benezra - Edges - Inspiration Board#20sdbenezra wants to merge 5 commits intoAda-C10:masterfrom
sdbenezra wants to merge 5 commits intoAda-C10:masterfrom
Conversation
Inspiration BoardWhat We're Looking For
Nicely done on this Sigrid! I have a few comments on code style, and you're largely missing snapshot testing, but otherwise it's a good submission. Good work |
tildeee
reviewed
Dec 20, 2018
|
|
||
| addCardCallback = (cardInfo) => { | ||
| // console.log("Board message - addCardCallback triggered"); | ||
| axios.post('https://inspiration-board.herokuapp.com/boards/sig/cards', cardInfo) |
There was a problem hiding this comment.
Hm, it'd be nice if you could have used the props boardName and url with this too
tildeee
reviewed
Dec 20, 2018
| console.log(`This is the index from card props: ${this.props.index}`); | ||
| console.log(`This is the id from card props: ${this.props.id}`); | ||
| this.props.onDeleteCallback(this.props.index, this.props.id); | ||
| } |
There was a problem hiding this comment.
It might make more sense to define this function deleteCard outside of render but still within Card. Then, to reference it, you would use this.deleteCard
tildeee
reviewed
Dec 20, 2018
|
|
||
| Card.propTypes = { | ||
|
|
||
| onDeleteCallback: PropTypes.func, |
There was a problem hiding this comment.
Would expect index, id, text, and emoji to be declared in propTypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions