Semret Nicodimos - Inspiration-board - Edges#21
Open
snicodimos wants to merge 13 commits intoAda-C10:masterfrom
Open
Semret Nicodimos - Inspiration-board - Edges#21snicodimos wants to merge 13 commits intoAda-C10:masterfrom
snicodimos wants to merge 13 commits intoAda-C10:masterfrom
Conversation
…on of the code for wave1
Inspiration BoardWhat We're Looking For
Semret! Great work with this project. I have only a few comments on this code, and it seems like your snapshot tests fail, but just need to be updated! Other than that, I think you did a good job with this code. Great work! |
tildeee
reviewed
Dec 20, 2018
| }; | ||
| } | ||
| componentDidMount() { | ||
| axios.get('https://inspiration-board.herokuapp.com/boards/Semret/cards') |
There was a problem hiding this comment.
There might be a good way to use the props url and boardName that the App component passes in for this (you'd need to change the boardName that App defines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions