Skip to content

lindsay - edges - inspiration board#33

Open
elle-terch wants to merge 9 commits intoAda-C10:masterfrom
elle-terch:master
Open

lindsay - edges - inspiration board#33
elle-terch wants to merge 9 commits intoAda-C10:masterfrom
elle-terch:master

Conversation

@elle-terch
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. First I created the HTML form. Then I built functions that handled the submit. The Board passes in a callback function to accept inputs from the card form and add them to the API.
How did you learn how to use the API? I just read the documentation provided in the project description.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? I used the Component Did Mount function so when the Board component renders, it will do so with populated data.
Explain the purpose of a Snapshot test. To ensure that a component renders properly.
What purpose does Enzyme serve in testing a React app? It allows you to manipulate and test the DOM in a testing environment.

@tildeee
Copy link

tildeee commented Dec 20, 2018

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
Card Component renders the data provided as props x
Board Component takes a URL and renders the list of Cards and passes in callback functions x
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component x
API
GET request made in componentDidMount x
DELETE request made in callback function x
POST request made in callback function passed to NewCardForm component. x
Snapshot testing
Styling x
Overall

Nicely done on this project Lindsay! It looks great.

For some reason, adding a card with an emoji doesn't work for me -- the emoji doesn't show up :(

Also, it seems like you didn't get to snapshot testing on this project, which was a big learning goal :(

That being said, good work on this one! The code looks good!


componentDidMount() {
console.log("The component did in fact mount");
const GET_ALL_CARDS_URL = "https://inspiration-board.herokuapp.com/boards/lindsay/cards";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if you used the props passed into Board from App -- url and boardName!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants