lindsay - edges - inspiration board#33
Open
elle-terch wants to merge 9 commits intoAda-C10:masterfrom
Open
Conversation
Inspiration BoardWhat We're Looking For
Nicely done on this project Lindsay! It looks great. For some reason, adding a card with an emoji doesn't work for me -- the emoji doesn't show up :( Also, it seems like you didn't get to snapshot testing on this project, which was a big learning goal :( That being said, good work on this one! The code looks good! |
tildeee
reviewed
Dec 20, 2018
|
|
||
| componentDidMount() { | ||
| console.log("The component did in fact mount"); | ||
| const GET_ALL_CARDS_URL = "https://inspiration-board.herokuapp.com/boards/lindsay/cards"; |
There was a problem hiding this comment.
it would be nice if you used the props passed into Board from App -- url and boardName!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions