Michelle - Edges - Inspiration Board#40
Open
kangazoom wants to merge 10 commits intoAda-C10:masterfrom
Open
Conversation
Inspiration BoardWhat We're Looking For
Aw Michelle! Well, you know that this project is pretty incomplete. With what I saw though, it was the makings of a good start. I've added just a couple comments on the current code as is. Otherwise, just to be completely thorough, what I saw missing was:
You mention in your PR that mostly you ran out of time, but if you have any questions about the material, let me know. |
tildeee
reviewed
Dec 20, 2018
| } | ||
|
|
||
| componentDidMount() { | ||
| const GET_CARDS_URL = 'https://inspiration-board.herokuapp.com/boards/mightymichelle/cards'; |
There was a problem hiding this comment.
it would be nice if you used the props passed into Board from App -- url and boardName!
tildeee
reviewed
Dec 20, 2018
| let card = this.state.cards.find((card) => card.id === response.data.card.id); | ||
| let updatedCardCollection = this.state.cards.filter(element => element !== card); | ||
|
|
||
| this.setState({cards: updatedCardCollection}); |
There was a problem hiding this comment.
Hm, weird, the list of cards isn't immediately updating for me after deleting a card... I haven't looked into debugging this though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions