Hayden - Edges (C10) - Inspo Board#44
Open
halcyon-and-on wants to merge 3 commits intoAda-C10:masterfrom
Open
Conversation
…so cards can be deleted
…nt so cards can be added to board
Inspiration BoardWhat We're Looking For
|
| delCard = (id) => { | ||
| const url = 'https://inspiration-board.herokuapp.com/cards/' + id.toString(); | ||
|
|
||
| axios.delete(url) |
There was a problem hiding this comment.
You should use complete words for variable and function names. Your jargon may feel obvious to you, but it will often be less so to your coworkers.
|
|
||
| axios.post(url) | ||
| .then((res) => { | ||
| let newState = this.state; |
There was a problem hiding this comment.
I like that you've kept all the API interaction logic in one place - the callbacks are a little more complex, but I would say it makes the app as a whole much easier to comprehend. Whether or not you intended it, this is a great example of the container component pattern well-applied.
| <select className="new-card-form__form-select" name="emoji" onChange={this.onFormChange}> | ||
| <option value=""></option> | ||
| <option value="heart_eyes">😍</option> | ||
| <option value="beer">🍺</option> |
There was a problem hiding this comment.
Could you generate these <option> tags dynamically from EMOJI_LIST?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions