Skip to content

Melissa : Edges : Inspiration Board#45

Open
melicious-dish wants to merge 1 commit intoAda-C10:masterfrom
melicious-dish:master
Open

Melissa : Edges : Inspiration Board#45
melicious-dish wants to merge 1 commit intoAda-C10:masterfrom
melicious-dish:master

Conversation

@melicious-dish
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. That will be a POST request that uses axios that requests to the API. the board will be updated which will update the state (setState) and add the board to the end of the API
How did you learn how to use the API? I used Postman a lot and trial and error
What function did you use to place the GET request from the API to get the list of cards? Why use that function? componentDIdMount is the function to get the list of cards. This lifecycle methods is invoked immediately after updating occurs
Explain the purpose of a Snapshot test. It's used to compare future runs of the test with a snapshot of a component that is saved in a JSON file
What purpose does Enzyme serve in testing a React app? It's a library that makes it easier to manipulate the components

@tildeee
Copy link

tildeee commented Dec 21, 2018

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene no git habit on this one
Comprehension questions x
General
Card Component renders the data provided as props x
Board Component takes a URL and renders the list of Cards and passes in callback functions
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component
API
GET request made in componentDidMount x
DELETE request made in callback function
POST request made in callback function passed to NewCardForm component.
Snapshot testing
Styling x
Overall

Hi Melissa--

I think you know that this one is very incomplete. Just to be clear, the things I saw missing were:

  • Being able to delete a card
  • Being able to create a card from a form
  • having snapshot tests

Also, although I'm very happy with your app getting the card list from the API in the correct way, you didn't use the URL with your own custom board name (you are grabbing from the Ada-Lovelace board), which is against directions.

Overall, I think you did almost did a good job with what you have submitted. I want to make sure that if you have questions, you get those answers. Let me know what's up and what we can do during capstone so you don't fall behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants