Open
Conversation
CheezItMan
reviewed
May 20, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really well done Pauline, nice work. I appreciate how you got these done ASAP.
Comment on lines
+2
to
12
| # Time Complexity - O(v + e) Using BFS, the function checks each vertex through the queue once, and all edges | ||
| # associated with that queue once or twice at most. Checking for non biparition-able graphs via edges beforehand | ||
| # and only adding to the queue any edges with vertices that haven't been visited as a vertex prevents | ||
| # repeat vertices from being visited. | ||
|
|
||
| # Space Complexity - O(v) - A hash, and set, and a queue are created where the max number of elements added will never exceed | ||
| # the number of vertices (v) in the graph. group_hash will always have two keys between which the vertices are divided into based on | ||
| # edges, to_visit is a set of all vertices to delete from (in O(1) time), while bfs at worst will have all vertices in the Queue, | ||
| # as the function doesn't add any edges that have already been visited. to_visit mostly exists to track any vertices | ||
| # in a graph that aren't reached by a group of other vertices in the graph, which group_hash and bfs_q can't account for. | ||
| def possible_bipartition(dislikes) |
There was a problem hiding this comment.
Nice implementation of Breadth-first-search. Well done!
Comment on lines
+20
to
+24
| # set current group for leading vertex | ||
| v_group = 1 | ||
|
|
||
| # set current group for edges | ||
| e_group = 2 |
There was a problem hiding this comment.
This works to label the groups, I just used the symbols :red, and :green to label the groups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will update with any improvements as I revisit. Thank you!!