Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def max_sub_array(nums)
Comment on lines +2 to 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but you can actually do it without the array. You only need to keep track of the max subarray ending at the current index and the max subarray seen so far.

It's kind of like the fibonacci problem.

That said your time complexity is great.

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
array_of_max_sum_ending_in_i = []
array_of_max_sum_ending_in_i[0] = nums[0]

i = 1
while i < nums.length do
array_of_max_sum_ending_in_i[i] = [array_of_max_sum_ending_in_i[i - 1] + nums[i], nums[i]].max
i += 1
end
Comment on lines +9 to +12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so compact!

return array_of_max_sum_ending_in_i.max
end
19 changes: 16 additions & 3 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@


# Time complexity: ?
# Space Complexity: ?
# Time complexity: O(n)
# Space Complexity: O(n)
def newman_conway(num)
Comment on lines +3 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "newman_conway isn't implemented"
pairs = {1=>1, 2=>1}
return "1" if num == 1
raise ArgumentError if num < 1

values = "1 1"
i = 3

until i > num
pairs[i] = pairs[pairs[i - 1]] + pairs[i - pairs[i - 1]]
values += " " + pairs[i].to_s
i += 1
end

return values
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down