Open
Conversation
CheezItMan
reviewed
May 3, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Aimee, I had a small comment, but this is quite well done.
Comment on lines
+4
to
6
| // Time Complexity: O(nlog(n))- both for loops are O(n), heap.add and heap.remove are O(log(n)) | ||
| // Space Complexity: O(n) - the store array of minHeap has a space complexity of O(n) | ||
| function heapsort(list) { |
Comment on lines
+14
to
16
| // Time Complexity: O(log(n)) - Recursive calls (uses heapUp) | ||
| // Space Complexity: O(log(n)) - Recursive calls, log(n) calls in memory (because of heapUp) | ||
| add(key, value = key) { |
Comment on lines
+53
to
55
| // Time complexity: O(1) - the length property is a quick look up | ||
| // Space complexity: O(1) - saving the length of the array will be constant memory | ||
| isEmpty() { |
Comment on lines
+26
to
28
| // Time Complexity: O(log(n)), recursive (uses heapDown, similar to heapUp) | ||
| // Space Complexity: O(log(n)), log(n) recursion calls (uses heapDown) | ||
| remove() { |
Comment on lines
+76
to
+80
| if (index % 2 === 0) { | ||
| parentIndex = (index - 2) / 2; | ||
| } else { | ||
| parentIndex = (index - 1) / 2; | ||
| } |
There was a problem hiding this comment.
Could you use floor to simplify this a bit?
Comment on lines
93
to
96
| // This helper method takes an index and | ||
| // moves it up the heap if it's smaller | ||
| // than it's parent node. | ||
| heapDown(index) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?