Open
Conversation
CheezItMan
reviewed
May 6, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work Emily. I had one comment on heap-down, but otherwise solid work.
Comment on lines
+4
to
7
| // Time Complexity: O(nlogn)? | ||
| // Space Complexity: O(n)? | ||
|
|
||
| function heapsort(list) { |
There was a problem hiding this comment.
👍 Very clean!
Correct time/space complexity. No need for question marks!
Comment on lines
+26
to
28
| // Time Complexity: O(logn)? | ||
| // Space Complexity: 0(1)? | ||
| remove() { |
Comment on lines
+53
to
55
| // Time complexity: O(1) | ||
| // Space complexity: O(1) | ||
| isEmpty() { |
Comment on lines
+62
to
64
| // Time complexity: O(1) Because we're only swapping?? | ||
| // Space complexity: O(1)? | ||
| heapUp(index) { |
There was a problem hiding this comment.
You're doing recursion so the time complexity is O(log n) and space complexity is the same (system stack).
| // This helper method takes an index and | ||
| // moves it up the heap if it's smaller | ||
| // than it's parent node. | ||
| heapDown(index) { |
There was a problem hiding this comment.
What about the situation if there is no right child, but there is a left child?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not finished!
Would like some feedback on what is causing my last test in heapsort to fail. I realize there's something wrong with my heapDown(index) method in minheap.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?