Open
Conversation
…work if negative values were in the list
CheezItMan
reviewed
Mar 23, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Christabel, you hit the main learning goals here. I left a few comments, but otherwise this is very well done.
Comment on lines
+20
to
23
| Time Complexity: O(1) | ||
| Space Complexity: O(1) | ||
| */ | ||
| addFirst(value) { |
Comment on lines
+30
to
33
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| search(value) { |
Comment on lines
+45
to
48
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findMax() { |
| */ | ||
| findMin() { | ||
| throw new Error("This method hasn't been implemented yet!"); | ||
| let min = null; |
There was a problem hiding this comment.
Maybe instead assign min to the 1st element in the linked list. Then you don't have to worry about if min is null.
Comment on lines
+83
to
86
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| length() { |
Comment on lines
+226
to
229
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| hasCycle() { |
There was a problem hiding this comment.
This won't handle a cycle which does not include the head.
Comment on lines
+276
to
279
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| getLast() { |
Comment on lines
+292
to
295
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| insertAscending(value) { |
Comment on lines
+183
to
186
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findMiddleValue() { |
Comment on lines
+200
to
203
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findNthFromEnd(n) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.