Open
Conversation
CheezItMan
reviewed
Sep 22, 2020
Collaborator
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Maha, this hits all the learning goals here. Well done.
| # Space complexity: ? | ||
| # call on the length method to print | ||
| # wy can't I see this test fail message when rake | ||
| def print_array(array) |
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # no each | ||
| def length(array) |
| # Returns true if found, false otherwise. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def search(array, length, value_to_find) |
| # Assumes that the array is not sorted #linear search | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def find_largest(array, length) |
Comment on lines
84
to
86
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def find_smallest(array, length) |
| # Reverses the values in the integer array in place | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def reverse(array, length) |
Comment on lines
121
to
123
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def binary_search(array, length, value_to_find) |
Collaborator
There was a problem hiding this comment.
👍 , some indentation improvements could be done here.
Comment on lines
+127
to
+129
| if length < 1 | ||
| exit | ||
| end |
Collaborator
There was a problem hiding this comment.
Suggested change
| if length < 1 | |
| exit | |
| end | |
| if length < 1 | |
| exit | |
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.