Iris & Noor

[iris-lux]

Assignment Submission: Rideshare Rails

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These questions should be answered by all team members together, not by a single teammate.

Reflection

Prompt	Response
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Driver has many Trips, passenger has many trips, and Trip belongs to Passenger and Driver. We set it up that way so we'd be able to access the data and the relationship between entities easily.
Describe the role of model validations in your application	We created validations for all models. We made sure info like Vins and ratings conformed to a certain standard, and we made sure certain essential info was present (such as names for drivers/passengers).
How did your team break up the work to be done?	Iris focused more on the back-end, such as models, and Noor focused on the front-end views. Both contributed to controllers/controller tests.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized functionality over style, our stylesheets are simpler yet elegant.
What was one thing that your team collectively gained more clarity on after completing this assignment?	How models function, and the relationships between models.
What are two discussion points that you and your team discussed when giving/receiving feedback from each other that you would be willing to share?	Flexibility on both sides was appreciated. We had good communication around gitpush/pull which prevented confusion and code issues.
Optional: What is the URL of your deployed Heroku app?

[CheezItMan]

Rideshare Rails

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices collaborating with git, and all team members contribute git commits and best git practices	✔️
Demonstrates understanding of relationships by giving accurate answers to the reflection questions and appropriate code in the models	✔️
Logic to calculate a driver's average rating and total earnings is located in the model, and it has unit tests	✔️, however you need to test some edge cases see my inline methods.
There are reasonable tests to test the validation requirements for all models	✔️
There are reasonable tests to test the relationship requirements for all models	✔️
There are reasonable tests to test the controller actions for all controllers	✔️
The app has an attractive and usable user interface	✔️, although I think things would look better in a table-like format.
The app uses/is compatible with database seeds	✔️
Router code is clean: uses resources and RESTful routes	✔️, however see some of my notes

Functional Requirements

Functional Requirement	yes/no
On the passenger's details page, I want to be able to see total charged, list of trips, a link to edit, and delete	✔️
When adding a new passenger, I want to see errors and validations that show that a passenger must be provided a name and a phone number, so that I cannot make a passenger without name or phone number	✔️
On the passenger's details page, I can create a new trip for this passenger, with an assigned driver and no rating	✔️
On the driver's details page, I want to be able to see total earnings, average rating, list of trips, a link to edit, and delete	✔️
When adding a new driver, I want to see errors and validations that show that a driver must be provided a name and VIN, so that I cannot make a driver without name or VIN	✔️
On the trip's detail page, I want to be able to view details, assign a rating, navigate to the trip's passenger, driver, a link to edit, and delete	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 5+ in Functional Requirements

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Summary

Really well done. You hit the learning goals here. I like some of your helper methods and you have some good tests too. However you needed to test some edge cases on the custom methods, and I found a few smaller things to make note of, status codes, etc. Take a look and let me know what questions you have.

[CheezItMan]

🙅

Suggested change

raise

[CheezItMan]

I think you intended to try to give a rating to an invalid trip.

Suggested change

	it "will redirect to the trips page if given an invalid id" do
	# Your code here
	id = -1
	delete trip_path(id)
	must_redirect_to trips_path
	end
	it "will redirect to the trips page if given an invalid id" do
	# Your code here
	id = -1
	expect{
	patch assign_rating_trip_path(id), params: {rating: 4}
	}.wont_change "Trip.count"
	must_redirect_to trips_path
	end

[CheezItMan]

What about if the user submits an update, but violates a validation?

[CheezItMan]

What about creating an invalid trip?

[CheezItMan]

What about updating a passenger with invalid data?

[CheezItMan]

Do you need this? You have resources.

[CheezItMan]

What about a passenger with no trips?

[CheezItMan]

What about a driver with no trips?

[CheezItMan]

What about a driver with no trips?

[CheezItMan]

Suggested change

	if result
	if result.valid?