Earth - Beauttie & Water - Mackenzie by beauttie · Pull Request #20 · Ada-C14/ride-share-rails

beauttie · 2020-11-07T01:31:44Z

Assignment Submission: Rideshare Rails

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These questions should be answered by all team members together, not by a single teammate.

Reflection

Prompt	Response
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Passenger and Driver can have zero or many Trips, and a Trip belongs to a Driver and Passenger (to create these entity relationships when seeding the data and connect the trips to a driver and passenger).
Describe the role of model validations in your application	To ensure appropriate information is entered for each attribute so that our model methods can run with no errors and to notify the user why the input is invalid
How did your team break up the work to be done?	We mostly did the work together and switched between the roles of driver and navigator. We also did some research beforehand independently.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	Functionality was prioritized; look and feel was set aside.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Active Record relationships and database migrations
What are two discussion points that you and your team discussed when giving/receiving feedback from each other that you would be willing to share?	We established that we both wanted straightforward feedback and a routine for collaboration via Slack.
Optional: What is the URL of your deployed Heroku app?	NA

…display costs

… controllers for destroy to address .nil

CheezItMan

Rideshare Rails

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices collaborating with git, and all team members contribute git commits and best git practices	✔️
Demonstrates understanding of relationships by giving accurate answers to the reflection questions and appropriate code in the models	✔️
Logic to calculate a driver's average rating and total earnings is located in the model, and it has unit tests	✔️
There are reasonable tests to test the validation requirements for all models	✔️
There are reasonable tests to test the relationship requirements for all models	✔️
There are reasonable tests to test the controller actions for all controllers	✔️
The app has an attractive and usable user interface	✔️
The app uses/is compatible with database seeds	✔️
Router code is clean: uses `resources` and RESTful routes	✔️

Functional Requirements

Functional Requirement	yes/no
On the passenger's details page, I want to be able to see total charged, list of trips, a link to edit, and delete	✔️
When adding a new passenger, I want to see errors and validations that show that a passenger must be provided a name and a phone number, so that I cannot make a passenger without name or phone number	✔️
On the passenger's details page, I can create a new trip for this passenger, with an assigned driver and no rating	✔️
On the driver's details page, I want to be able to see total earnings, average rating, list of trips, a link to edit, and delete	✔️
When adding a new driver, I want to see errors and validations that show that a driver must be provided a name and VIN, so that I cannot make a driver without name or VIN	✔️
On the trip's detail page, I want to be able to view details, assign a rating, navigate to the trip's passenger, driver, a link to edit, and delete	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 5+ in Functional Requirements

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Summary

Nice work, y'all hit the learning goals. Well done. I left comments on several minor issues throughout the app. Please look at them and let me know what questions you have.

CheezItMan · 2020-11-12T03:57:47Z

.gitignore

+
+/public/assets
+.byebug_history
+


I suggest you add .idea to the .gitignore file.

Suggested change

.idea

CheezItMan · 2020-11-12T04:00:06Z

app/controllers/drivers_controller.rb

+      redirect_to drivers_path
+      return
+    else
+      redirect_to driver_path(@driver.id)


So if the driver has trips you can't delete them?

CheezItMan · 2020-11-12T04:00:55Z

app/controllers/passengers_controller.rb

+    elsif @passenger.trips.empty?
+      @passenger.destroy
+      redirect_to passengers_path
+      return
+    else
+      redirect_to passenger_path(@passenger.id)
+      return
+    end


So if the passenger has trips, they can't be destroyed.

CheezItMan · 2020-11-12T04:08:04Z

app/models/driver.rb

@@ -0,0 +1,19 @@
+class Driver < ApplicationRecord


Good validations and methods

CheezItMan · 2020-11-12T04:08:36Z

app/views/drivers/edit.html.erb

+<% if @driver.errors.any? %>
+  <ul class="errors">
+    <% @driver.errors.each do |column, message| %>
+      <li><strong><%= column %></strong> <%= message %></li>
+    <% end %>
+  </ul>
+<% end %>


Why not put this into the partial?

CheezItMan · 2020-11-12T04:09:38Z

app/views/drivers/show.html.erb

+<ol>
+  <% @driver.trips.each do |trip| %>
+    <li> ID: <%= link_to trip.id, trip_path(trip) %> --
+      Driver: <%= trip.driver.name %> --
+      Passenger: <%= trip.passenger.name %> --
+      Cost: <%= number_to_currency(trip.cost/100) %> --
+      Rating: <%= trip.rating %>
+    </li>
+  <% end %>
+</ol>


Just noting this is a great candidate for a partial, anytime you need a list of trips, you can just call the partial.

CheezItMan · 2020-11-12T04:11:35Z

app/views/passengers/new.html.erb

@@ -0,0 +1,13 @@
+<h2>New Passenger</h2>


You don't need this file!

CheezItMan · 2020-11-12T04:12:51Z

config/routes.rb

+  root to: 'homepages#index'
+
+  resources :passengers do
+    resources :trips, only: [:index, :create]


You're not really using index as a nested route.

CheezItMan · 2020-11-12T04:19:21Z

app/models/trip.rb

+  belongs_to :passenger
+  belongs_to :driver
+
+  validates :rating, allow_nil: true, numericality: { only_integer: true, greater_than_or_equal_to: 1, less_than_or_equal_to: 5 }


No validation for cost?

CheezItMan · 2020-11-12T04:20:15Z

app/models/passenger.rb

+
+  validates :name, presence: true
+  validates :phone_num, presence: true, uniqueness: true
+


I would also add a method to request_trip

beauttie and others added 30 commits November 2, 2020 14:35

Run rails new

eab51a1

Create models for Driver, Passenger, Trip and migrated them

01a17f6

Create controllers and resources as routes

9309be7

index and show methods and views for passenger and driver

b527fec

Create controller and index view for homepage

c064099

added new and edit to views, controller

fd7cdcd

Add new and edit to controller and views for driver

a3c651b

create active record relationships, db migrations, re-seeded db

e554cbb

display trip data in Passenger show

d41bd43

Add model logic to drivers and passengers, update views

ccbd080

Add nested routes, validate AR for passenger and driver

4ca458a

Create partials for driver views

3090a1b

trip forms, passenger forms

5614ae3

Print errors from validations on new view

a4d7a0b

Fix argument in redirect_to method

b3fa1cc

new trip issue

8323e97

def create for trips worksssss

1518320

format change

5da7d61

Delete new controller action and its view, use number_to_currency to …

b0f9077

…display costs

driver avaialbility default, trip update, driver new

48ac746

Add controller tests for index, show, new

4817a6a

starting testing, trips controller test for show does not work

6ea8b1e

Finish controller tests for Driver except for destroy

55b8814

passenger controller tests, all but destroy

4a36f3c

Revise validations for trip

f3cf9fa

Create destroy controller action for Drivers and Passengers

26833cb

passenger tests pass, driver tests pass, updated passenger and driver…

388adec

… controllers for destroy to address .nil

started trip testing

53da99c

Clean up driver controller tests

45f2908

Clean up passenger controller tests

20fd17c

beauttie and others added 12 commits November 6, 2020 01:33

Fix syntax of it blocks in trip controller test file

354152f

Edit footer of show view for trips

11df107

Change h1 tags to h2

1e4ac73

Finish trip controller tests

6ef9b27

model testing

ed3f4a2

driver_test passes

fc8bea4

passenger_test passes

b4f44fb

Finish trip model tests

956032d

added some css

ee3019c

solving final tests, mackenzie's debugger does not work

8a5d094

DRY up code

0db1434

Last edits hopefully

ca7785e

CheezItMan reviewed Nov 12, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Earth - Beauttie & Water - Mackenzie#20

Earth - Beauttie & Water - Mackenzie#20
beauttie wants to merge 42 commits intoAda-C14:masterfrom
beauttie:master

beauttie commented Nov 7, 2020

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		validates :name, presence: true
		validates :phone_num, presence: true, uniqueness: true


		/public/assets
		.byebug_history

Conversation

beauttie commented Nov 7, 2020

Assignment Submission: Rideshare Rails

Reflection

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Rideshare Rails

Major Learning Goals/Code Review

Functional Requirements

Overall Feedback

Code Style Bonus Awards

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants