Kal(Earth)xBeatrice(Fire) by kashenafi · Pull Request #21 · Ada-C14/ride-share-rails

kashenafi · 2020-11-07T01:49:38Z

Assignment Submission: Rideshare Rails

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These questions should be answered by all team members together, not by a single teammate.

Reflection

Prompt	Response
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trip belongs to passenger and driver so a trip can only have one passenger/driver. Driver and passenger have many trips each because that is what the data has and how it works in the real world.
Describe the role of model validations in your application	We wanted to make sure that each model had the appropriate attributes filled in. ‘Appropriate’ meaning as close to the real world application as possible.
How did your team break up the work to be done?	Made branches and worked on certain parts individually, then made and merged pull requests.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized basic CRUD for driver, passenger, and trip first. We set aside CSS until these were taken care of . We did not give the user the ability to complete a trip. We also did not use nested routes.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Git! Also, model testing, and how multiple controllers/models can interact
What are two discussion points that you and your team discussed when giving/receiving feedback from each other that you would be willing to share?	We both agreed that we could have split up more of the work both amongst ourselves and among the week - a lot of time on Zoom the past two days. We were both very pleased that we got a lot of practice in the roles we were weaker on (one of us was more comfortable driving and one being passenger and we switched that up a lot this project).
Optional: What is the URL of your deployed Heroku app?	https://space-rs.herokuapp.com/trips

…ex pages

Homepage root

Trip edit form + buttons for all index/show pages

Styling added

…into master

CheezItMan

Rideshare Rails

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices collaborating with git, and all team members contribute git commits and best git practices	✔️
Demonstrates understanding of relationships by giving accurate answers to the reflection questions and appropriate code in the models	✔️
Logic to calculate a driver's average rating and total earnings is located in the model, and it has unit tests	✔️
There are reasonable tests to test the validation requirements for all models	✔️
There are reasonable tests to test the relationship requirements for all models	✔️
There are reasonable tests to test the controller actions for all controllers	✔️
The app has an attractive and usable user interface	✔️, looks really nice
The app uses/is compatible with database seeds	✔️
Router code is clean: uses `resources` and RESTful routes	✔️

Functional Requirements

Functional Requirement	yes/no
On the passenger's details page, I want to be able to see total charged, list of trips, a link to edit, and delete	✔️
When adding a new passenger, I want to see errors and validations that show that a passenger must be provided a name and a phone number, so that I cannot make a passenger without name or phone number	✔️
On the passenger's details page, I can create a new trip for this passenger, with an assigned driver and no rating	✔️
On the driver's details page, I want to be able to see total earnings, average rating, list of trips, a link to edit, and delete	✔️
When adding a new driver, I want to see errors and validations that show that a driver must be provided a name and VIN, so that I cannot make a driver without name or VIN	✔️
On the trip's detail page, I want to be able to view details, assign a rating, navigate to the trip's passenger, driver, a link to edit, and delete	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 5+ in Functional Requirements

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Summary

Really well done. This hit all the learning goals here. I did have some suggestions around returning status codes and testing. However this is a very solid submission. Nice work!

CheezItMan · 2020-11-12T02:17:15Z

app/controllers/drivers_controller.rb

+      redirect_to driver_path(@driver.id)
+      return
+    else
+      render :new


It's best to include an HTTP status code.

Suggested change

render :new

render :new, status: :bad_request

CheezItMan · 2020-11-12T02:17:28Z

app/controllers/drivers_controller.rb

+      redirect_to driver_path(@driver.id)
+      return
+    else
+      render :edit


Suggested change

render :edit

render :edit, status: :bad_request

CheezItMan · 2020-11-12T02:17:48Z

app/controllers/passengers_controller.rb

+      redirect_to passenger_path(@passenger.id)
+      return
+    else
+      render :new


Suggested change

render :new

render :new, status: :bad_request

CheezItMan · 2020-11-12T02:18:02Z

app/controllers/passengers_controller.rb

+      redirect_to passenger_path(@passenger.id)
+      return
+    else
+      render :edit


Suggested change

render :edit

render :edit, status: :bad_request

CheezItMan · 2020-11-12T02:18:15Z

app/controllers/trips_controller.rb

+      redirect_to trip_path(@trip.id)
+      return
+    else
+      render :new


Suggested change

render :new

render :new, status: :bad_request

CheezItMan · 2020-11-12T02:23:53Z

test/models/driver_test.rb

-    describe "can go online" do
-      # Your code here
-    end
+    describe "total earnings" do


Also include a test for when the driver has no trips.

CheezItMan · 2020-11-12T02:26:59Z

test/models/passenger_test.rb


-    describe "complete trip" do
-      # Your code here
+    describe "total spent" do


You also need a test for when the passenger has no trips.

CheezItMan · 2020-11-12T02:28:18Z

test/models/trip_test.rb


  describe "validations" do
-    # Your tests go here
+    it "had a numeric cost" do


You should also test that the cost is not missing.

CheezItMan · 2020-11-12T02:31:00Z

app/views/layouts/application.html.erb

+    <div class="parallax">
+    <h1 class="title"><%= link_to "🛸Ride Share Control Panel🛸", root_path %></h1>


Interesting styling

CheezItMan · 2020-11-12T02:31:50Z

config/routes.rb

+
+  root to: 'homepages#index'
+
+  resources :trips


Noting that the trips new/create can be nested under passenger.

kashenafi and others added 30 commits November 2, 2020 14:22

Rails new

77e223f

controllers, views, and db migrate

327ef1b

Db: needs reset

3e16ed8

Changed migrations to have foreign keys and added model relations

e08d892

Trips index page created

d6e5675

Ran dos2unix to add .generators file

b72d157

Add driver#index view

fc2e854

Passenger index page added

334d298

Update view

3c9d2e2

Merge remote-tracking branch 'origin/driver_index_page' into master

9c1b31e

merged index pages

de94ef8

Dirver show page added

07b34c4

Wrote passenger show page

14c712f

Added trips#show view

b233e00

Added hyperlinks for all trips, passengers, drivers on #show and #ind…

4c79f6f

…ex pages

First draft of website with homepage and show/details working

7ca23b6

Added missing heading

e0707f7

Merge pull request #1 from kashenafi/homepage-root

51e5b4f

Homepage root

New driver & passenger forms added

7808c22

Edit actions & views added

05aa65b

Updated routes

db6bda8

Wrote trips edit form and view

27b9712

Added edit/delete buttons to all index pages

a0d2a4e

Added edit/delete buttons to all show pages

12607bb

Styling added

b223e9b

Merge pull request #2 from kashenafi/trips-edit

551f3eb

Trip edit form + buttons for all index/show pages

Merge branch 'master' into LowPriorityCSS

59c0ab4

Merge pull request #3 from kashenafi/LowPriorityCSS

20d082f

Styling added

Made homepage images transparent

ec11eb9

Fixed transparent images

ae2de28

kashenafi and others added 11 commits November 5, 2020 15:15

Destroy actions added

f52ab06

Merge branch 'master' of https://github.com/kashenafi/ride-share-rails …

1c372c8

…into master

Added validation & tests passing

1185afc

Driver tests written & passing

fb4602c

Wrote passenger controller tests

87cd4c5

request trip added

bab310d

Averages & totals on driver & passenger pages

efcac89

trips test almost complete

2dd73f4

comparing file differences

5d7bb64

Passenger and driver model tests completed & passing

b7bf547

all tests passing

09aad87

kashenafi changed the title ~~Earth+ Fire - Kal & Beatrice~~ Earth x Fire - Kal x Beatrice Nov 7, 2020

kashenafi changed the title ~~Earth x Fire - Kal x Beatrice~~ Kal x Beatrice Nov 7, 2020

kashenafi changed the title ~~Kal x Beatrice~~ Kal(Earth) x Beatrice(Fire) Nov 7, 2020

kashenafi changed the title ~~Kal(Earth) x Beatrice(Fire)~~ Kal(Earth)xBeatrice(Fire) Nov 10, 2020

CheezItMan reviewed Nov 12, 2020

View reviewed changes

kashenafi added 3 commits January 26, 2021 19:33

Update application.html.erb

b49f5f3

Update application.html.erb

ebb0cd1

Update application.html.erb

f679c4c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kal(Earth)xBeatrice(Fire)#21

Kal(Earth)xBeatrice(Fire)#21
kashenafi wants to merge 44 commits intoAda-C14:masterfrom
kashenafi:master

kashenafi commented Nov 7, 2020 •

edited

Loading

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

CheezItMan Nov 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		<div class="parallax">
		<h1 class="title"><%= link_to "🛸Ride Share Control Panel🛸", root_path %></h1>

Conversation

kashenafi commented Nov 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Assignment Submission: Rideshare Rails

Reflection

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Rideshare Rails

Major Learning Goals/Code Review

Functional Requirements

Overall Feedback

Code Style Bonus Awards

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kashenafi commented Nov 7, 2020 •

edited

Loading