Leah and Stacy's Ride-Share-Rails!

[StacyLundquist]

Assignment Submission: Rideshare Rails

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These questions should be answered by all team members together, not by a single teammate.

Reflection

Prompt	Response
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A trip belongs to one driver and one passenger; a passenger and a driver each have many trips. We set it up that way because only one driver and one passenger (currently) can be on the trip at the same time.
Describe the role of model validations in your application	The validations are set to ensure that each table value has proper requirements so that each driver/passenger/trip is a complete entry in the databases (without allowing people to use them for nefarious reasons).
How did your team break up the work to be done?	First we set up our Trello board (using the Swiss Alps, to set the calming mood), we assigned primary to-dos based off of comfort levels with the topic, then continually kept in touch (via Slack) and allowed the workload to flow from one item to the next. We were communicating and cheerleading continually, so there weren't any big mishaps!
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized user stories over tests.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Github and Git --merging, solving conflicts, branching...
What are two discussion points that you and your team discussed when giving/receiving feedback from each other that you would be willing to share?	We didn't have any super-serious discussion points, we both feel as if we are well-suited and communicate well together. We did have some discussion about taking breaks and going for walks.
Optional: What is the URL of your deployed Heroku app?	hahaha, uhhhhh :) Next time.

[beccaelenzil]

Rideshare Rails

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices collaborating with git, and all team members contribute git commits and best git practices	✔️
Demonstrates understanding of relationships by giving accurate answers to the reflection questions and appropriate code in the models	✔️
Logic to calculate a driver's average rating and total earnings is located in the model, and it has unit tests	✔️ Yes, and tests weren't required for this project.
There are reasonable tests to test the validation requirements for all models	✔️
There are reasonable tests to test the relationship requirements for all models	✔️
There are reasonable tests to test the controller actions for all controllers	There are 15 tests with errors, and 3 failures. I've made inline comments on a few of these. I'd be happy to go through more of them with you.
The app has an attractive and usable user interface	✔️ Love the flipping and colors!
The app uses/is compatible with database seeds	✔️ Some trips fail to save.
Router code is clean: uses resources and RESTful routes	There is an error with the custom availability route.

Functional Requirements

`

Functional Requirement	yes/no
On the passenger's details page, I want to be able to see total charged, list of trips, a link to edit, and delete	The show action fails for a passenger that has no trip: undefined method to_f' for []:Array ->	<%= number_to_currency(@passenger.total_charged.to_f / 100) %>
When adding a new passenger, I want to see errors and validations that show that a passenger must be provided a name and a phone number, so that I cannot make a passenger without name or phone number	✔️
On the passenger's details page, I can create a new trip for this passenger, with an assigned driver and no rating	The links to the trips on the passenger show page do not work because they are missing the trip_id from the path
On the driver's details page, I want to be able to see total earnings, average rating, list of trips, a link to edit, and delete	✔️ If I uncheck the available box when editing, there's a validation error that available can't be blank
When adding a new driver, I want to see errors and validations that show that a driver must be provided a name and VIN, so that I cannot make a driver without name or VIN	✔️
On the trip's detail page, I want to be able to view details, assign a rating, navigate to the trip's passenger, driver, a link to edit, and delete	✔️

Overall Feedback

Good work overall on this project. You implemented complex model relationships, excellent styles, and the request_trip feature works beautifully. There are a few bugs that lead to broken views and unexpected behavior that I tried to highlight in the rubric and through code comments. You also have multiple tests with errors. I encourage you to take some time to read through these errors and make corrections. Please let me know if you would like to look at it together.

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 5+ in Functional Requirements
Yellow (Approaches Standards)	5+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention	✔️
Red (Not at Standard)	0-4 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Descriptive/Readable	✅

[beccaelenzil]

This line produces an error.

The route you define is:
patch 'drivers/availability', to: 'drivers#availability', as: 'availability'
I think you meant to include the driver.id as a param:
patch 'drivers/:driver_id/availability', to: 'drivers#availability', as: 'availability'

  test_0001_can access the availability path                     ERROR (0.00s)
Minitest::UnexpectedError:         NoMethodError: undefined method `availability_path' for #<Minitest::Rails::SpecTests::Test__Driver_custom_methods_can_go_on_off_line__test_models_driver_test_rb__71:0x00007f92c0c88688>
            test/models/driver_test.rb:76:in `block (4 levels) in <main>'

[beccaelenzil]

This test fails. Consider the trip create method. To create a trip you need the :passenger_id from the params and a driver. You make use of the nested route that can be viewed by typing rails routes 👍
passenger_trips POST /passengers/:passenger_id/trips(.:format) trips#create

Consider how to write the test given this information and let me know if you have questions.

TripsController::create
  test_0001_can create a new trip                                 FAIL (0.01s)
        1.
        "Trip.count" didn't change
        test/controllers/trips_controller_test.rb:40:in `block (3 levels) in <main>'

[beccaelenzil]

This line produces an error. Remember passenger_path needs an id

[beccaelenzil]

These tests are tests of controller actions.

[beccaelenzil]

Good use of limiting nested routes.

[beccaelenzil]

Missing :driver_id from this route (I think). See comment on test.

[beccaelenzil]

The trip_path needs a trip or trip_id

Suggested change

	<li>Trip: <%= link_to trip.date, trip_path %>
	<li>Trip: <%= link_to trip.date, trip_path(trip) %>