Fire - Ayesha & Roshni

[roshni-patel]

Assignment Submission: Rideshare Rails

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These questions should be answered by all team members together, not by a single teammate.

Reflection

Prompt	Response
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Both passengers and drivers can have many trips. Each trip belongs to one driver and one passenger.
Describe the role of model validations in your application	Model validations are important for ensuring that the data is valid. For example, if a user tries to create a driver without entering a valid VIN or name, our program will raise an error and let the user know politely to enter the required information.
How did your team break up the work to be done?	We alternated driving and navigating through the implementation of code and tests. Toward the end of the project, we split up tasks but made sure to check in with each other to iron out some of the larger details.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized functionality, navigation, and user usability. We didn't spend as much time on styling as we wanted to ensure that we understood the primary learning concepts for the project.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained more clarity on the MVC concept/structure.
What are two discussion points that you and your team discussed when giving/receiving feedback from each other that you would be willing to share?	Ayesha mentioned that she found it helpful to be able to lead the project when she was in the driver's seat and feel the ownership equally while designing and implementing the project. We were both very appreciative that we were respectful of each other's teamwork guidelines and made sure to not to invade the other person's comfort level.
Optional: What is the URL of your deployed Heroku app?

[CheezItMan]

Rideshare Rails

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices collaborating with git, and all team members contribute git commits and best git practices	✔️
Demonstrates understanding of relationships by giving accurate answers to the reflection questions and appropriate code in the models	✔️
Logic to calculate a driver's average rating and total earnings is located in the model, and it has unit tests	✔️
There are reasonable tests to test the validation requirements for all models	✔️, yes, but you 're missing a test for the numericality of rating.
There are reasonable tests to test the relationship requirements for all models	✔️
There are reasonable tests to test the controller actions for all controllers	✔️
The app has an attractive and usable user interface	✔️, although more table-like styling woudl be an improvement. Also and more importantly some of the text is hard to read. Lastly the trips index page is just a list of ids.
The app uses/is compatible with database seeds	✔️
Router code is clean: uses resources and RESTful routes	✔️

Functional Requirements

Functional Requirement	yes/no
On the passenger's details page, I want to be able to see total charged, list of trips, a link to edit, and delete	✔️, yes but expenses is not displayed as money. Further the list of trips is just a list of id numbers... you should show more information.
When adding a new passenger, I want to see errors and validations that show that a passenger must be provided a name and a phone number, so that I cannot make a passenger without name or phone number	⚠️, No validation error messages for the most part.
On the passenger's details page, I can create a new trip for this passenger, with an assigned driver and no rating	✔️
On the driver's details page, I want to be able to see total earnings, average rating, list of trips, a link to edit, and delete	✔️
When adding a new driver, I want to see errors and validations that show that a driver must be provided a name and VIN, so that I cannot make a driver without name or VIN	⚠️, No validation error messages for the most part.
On the trip's detail page, I want to be able to view details, assign a rating, navigate to the trip's passenger, driver, a link to edit, and delete	✔️?

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 5+ in Functional Requirements	👍🏽

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Descriptive/Readable	✅
Logical/Organized	✅

Summary

Overall nice work, y'all hit the learning goals well. I have some criticisms and you can find them inline in the code review. The biggest things revolve around giving the user feedback when they do something not allowed.

[CheezItMan]

👍 Nice!

[CheezItMan]

Good use of an argument error.

[CheezItMan]

You should do something to handle if there is a error creating the trip.

[CheezItMan]

Again I would suggest re-rendering the new passenger form and displaying validation errors.

[CheezItMan]

👍

[CheezItMan]

Like new I suggest re-rendering :edit and displaying validation errors.

[CheezItMan]

No validation or relationship tests?

[CheezItMan]

No tests for ratings?