Ride-share-rails. Pauline Chane - Gessica E. Mohr

[GeMath18]

Assignment Submission: Rideshare Rails

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These questions should be answered by all team members together, not by a single teammate.

Reflection

Prompt	Response
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	For Driver model : we set up " has_many :trips " because one driver can have many trips. For Passenger model: we set up " has_many :trips " because one passenger can have many trips. For trip model: we set up "belongs_to : driver" and "belongs_to :passenger" because one trip belongs to one driver and on trip belongs to one passenger.
Describe the role of model validations in your application	The model validations allowed us to properly calculate certain statistics for each of our models. For instance, the “available” field in the Driver model had to be true or false so that we could verify if the driver could be matched with a trip. From the Trip model, the rating had to be verified to be within a certain range and had to be a number so that a Driver model could pull all its associated trips and obtain an average rating for those that have been finished. Likewise with the “cost” field, it was important for this field to be a numerical value to allow the Driver to pull their total earnings for all trips and the Passenger to pull their total spendings.
How did your team break up the work to be done?	We created a kanban board through Github/Projects and created a to-do list and assigned a task to one member. It was pretty open who wanted to work in what and both parties where happy to work on whatever was on the list. It was a good balance. Before and after each session we synched on what else we needed to do for the project. we created branches to avoid conflict of work and always made sure we did the proper pull/push actions. We had minimal problems with git.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We first prioritized getting working Driver and Passenger MVC with CRUD actions and RESTful routing, as well as finishing the tests. We then focused on linking the Trip model to the Driver and Passenger model, then completing the Trip MVC with CRUD actions and tests. Finally, for all models and controllers, we worked on the custom methods for each model and any additional Trip functionalities, such as going to a rating page to give a rating, and completed tests, followed by some minor adjustments to the views and CSS for legibility.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained more clarity on how to work side by side on controllers with tests, views, and models with tests. We didn't want to wait to the last minute to work on tests. Also validation was very important during the entire project and we both learned and gained more practice using them to be able to create MVC.
What are two discussion points that you and your team discussed when giving/receiving feedback from each other that you would be willing to share?	We talked about how good we were able to balance the work load on this project. Always praising each other for our accomplishments. This is our second time working together, and we both noticed how much knowledge and confidence we have gained since doing Adagrams. The use of the Kanban board was huge key to keep us on track and make sure we were not stressing out on completing the project since this time we weren't given Waves.
Optional: What is the URL of your deployed Heroku app?	We didn't deploy Heroku app and Pauline wants to add the she has done before and still broke her app.

[jmaddox19]

Rideshare Rails

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices collaborating with git, and all team members contribute git commits and best git practices	✔️ So many good commits from both of you!
Demonstrates understanding of relationships by giving accurate answers to the reflection questions and appropriate code in the models	✔️
Logic to calculate a driver's average rating and total earnings is located in the model, and it has unit tests	✔️ Yes! With thorough testing!
There are reasonable tests to test the validation requirements for all models	✔️
There are reasonable tests to test the relationship requirements for all models	✔️
There are reasonable tests to test the controller actions for all controllers	✔️
The app has an attractive and usable user interface	✔️
The app uses/is compatible with database seeds	✔️
Router code is clean: uses resources and RESTful routes	✔️

Functional Requirements

Functional Requirement	yes/no
On the passenger's details page, I want to be able to see total charged, list of trips, a link to edit, and delete	✔️
When adding a new passenger, I want to see errors and validations that show that a passenger must be provided a name and a phone number, so that I cannot make a passenger without name or phone number	✔️
On the passenger's details page, I can create a new trip for this passenger, with an assigned driver and no rating	✔️ Yes, and LOVE the Rate button with the separate rating page!
On the driver's details page, I want to be able to see total earnings, average rating, list of trips, a link to edit, and delete	✔️
When adding a new driver, I want to see errors and validations that show that a driver must be provided a name and VIN, so that I cannot make a driver without name or VIN	✔️
On the trip's detail page, I want to be able to view details, assign a rating, navigate to the trip's passenger, driver, a link to edit, and delete	✔️

Overall Feedback

Great work y'all! You made a fully functional website to manage a ride share service in just a few days! So cool! I hope y'all were able to celebrate this big win together!

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	7+ in Code Review && 5+ in Functional Requirements	✔️
Yellow (Approaches Standards)	5+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard)	0-4 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅