Skip to content

Water - Christabel#2

Open
cescarez wants to merge 16 commits intoAda-C14:masterfrom
cescarez:master
Open

Water - Christabel#2
cescarez wants to merge 16 commits intoAda-C14:masterfrom
cescarez:master

Conversation

@cescarez
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Christabel, you hit the learning goals here. Well done!

Comment on lines +5 to 8
Time Complexity: O(n)
Space Complexity: O(n)
*/
const balanced = (str) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +48 to 51
Time Complexity: O(n)
Space Complexity: O(n)
*/
const evaluatePostfix = (expr) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


enqueue(element) {
throw new Error("This method has not been implemented!");
enqueue(value) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

this.store[this.rear] = value;
}

dequeue() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return dequeued;
}

front() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return this.store[front];
}

size() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I'm not sure this this will work in all cases.

Comment on lines +49 to +53
if (this.front == this.rear) {
return true;
} else {
return false;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just do this

Suggested change
if (this.front == this.rear) {
return true;
} else {
return false;
}
return this.front == this.rear;

@@ -1,19 +1,31 @@
const LinkedList = require("./linked-list");

class Stack {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants