Open
Conversation
CheezItMan
reviewed
Apr 28, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done Ringo, you hit the learning goals. I had one comment on dequeue, but otherwise this works well.
Comment on lines
+3
to
8
| Time Complexity: O(n), the function has to visit every node once | ||
| but operations performed in that loop are O(1) | ||
| Space Complexity: O(n), worst case scenario the stack could have on it | ||
| every character in the string | ||
| */ | ||
| const balanced = (str) => { |
Comment on lines
+27
to
34
| Time Complexity: O(n), the function has to check every character in expr, | ||
| but operations in the for loop are O(1) | ||
| Space Complexity: O(n), the controlling factor is the height of the stack, | ||
| which does not grow quickly with longer expr in a normal use case but I suppose | ||
| in a worst case scenario with some weird postfix expressions would increase in size | ||
| linear to the length of the weird expression you were using | ||
| */ | ||
| const evaluatePostfix = (expr) => { |
| } | ||
| } | ||
|
|
||
| dequeue() { |
There was a problem hiding this comment.
👍 Very compact! However what happens if you dequeue an empty queue?
| this.tail = 0; | ||
| } | ||
|
|
||
| enqueue(element) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.