Open
Conversation
CheezItMan
reviewed
Apr 15, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Great work Kareha, you hit the learning goals here. Well done. I have one comment on one of the problems, otherwise very well done.
Comment on lines
+3
to
5
| # Time Complexity: O(n*m) | ||
| # Space Complexity: O(m), but also potentially O(1) | ||
| def balanced(string) |
There was a problem hiding this comment.
👍 Since you're building a stack it can't be O(1)
lib/problems.rb
Outdated
| stack = Stack.new | ||
|
|
||
| string.each_char do |char| # time: O(n) | ||
| if hash_table.has_value?(char) # time: O(m)? |
There was a problem hiding this comment.
I don't think you need to use has_value here.
I think better something like this
matching_braces = {
"}" => "{",
")" => "(",
"]" => "[",
}
stack = Stack.new
string.each_char do |char|
if ! matching_braces[char]
stack.push(char)
elsif matching_braces[char] != stack.pop()
return false
end
end
return stack.empty()
Comment on lines
+22
to
24
| # Time Complexity: O(n) | ||
| # Space Complexity: O(m), but also potentially O(1) | ||
| def evaluate_postfix(postfix_expression) |
There was a problem hiding this comment.
👍 , but the space and time complexities are O(n)
| @front = @back = -1 | ||
| end | ||
|
|
||
| def enqueue(element) |
| @store[@back] = element | ||
| end | ||
|
|
||
| def dequeue |
Comment on lines
40
to
50
| def front | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store[@front] | ||
| end | ||
|
|
||
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store.select{|x| !x.nil?}.length | ||
| end | ||
|
|
||
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| @store.map{|x| x.nil?}.all? | ||
| end |
| @store.map{|x| x.nil?}.all? | ||
| end | ||
|
|
||
| def to_s |
| @@ -1,19 +1,18 @@ | |||
| class Stack | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
push- add element to stack 2.pop- remove top element from stack 3.is_empty?- boolean, return true if stack is empty, else return falseenqueue- add to back of queue 2.dequeue- remove from front of queue 3.is_empty- boolean, return true if queue is empty, else return falseOPTIONAL JobSimulation