-
Notifications
You must be signed in to change notification settings - Fork 110
Cheetahs - Ev #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cheetahs - Ev #104
Changes from all commits
646d217
b8542d8
69b02da
618b9b1
23d70fd
92f7dbe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,10 @@ | ||
| class Clothing: | ||
| pass | ||
| from .item import Item | ||
|
|
||
| class Clothing(Item): | ||
| category = "Clothing" | ||
|
|
||
| def __init__(self, condition = 0): | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): | ||
| return "The finest clothing you could wear." | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,10 @@ | ||
| class Decor: | ||
| pass | ||
| from .item import Item | ||
|
|
||
| class Decor(Item): | ||
| category = "Decor" | ||
|
|
||
| def __init__(self, condition = 0): | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): | ||
| return "Something to decorate your space." |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,10 @@ | ||
| class Electronics: | ||
| pass | ||
| from .item import Item | ||
|
|
||
| class Electronics(Item): | ||
| category = "Electronics" | ||
|
|
||
| def __init__(self, condition = 0): | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): | ||
| return "A gadget full of buttons and secrets." |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,23 @@ | ||
| class Item: | ||
| pass | ||
| def __init__(self, category = None, condition = 0): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Category can be set to |
||
| if category == None: | ||
| category = "" | ||
| self.category = category | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): | ||
| return ("Hello World!") | ||
|
|
||
| def condition_description(self): | ||
| if self.condition == 0: | ||
| return "Heavily used" | ||
| elif self.condition == 1: | ||
| return "Pretty used" | ||
| elif self.condition == 2: | ||
| return "Obviously used" | ||
| elif self.condition == 3: | ||
| return "Meh, still has life left" | ||
| elif self.condition == 4: | ||
| return "Light wear" | ||
| elif self.condition == 5: | ||
| return "Minty" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,50 @@ | ||
|
|
||
| class Vendor: | ||
| pass | ||
| def __init__(self, inventory = None): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| if inventory == None: | ||
| inventory = [] | ||
| self.inventory = inventory | ||
|
|
||
| def add(self, item): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| self.inventory.append(item) | ||
| return item | ||
|
|
||
| def remove(self, item): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| if item in self.inventory: | ||
| self.inventory.remove(item) | ||
| return item | ||
| else: | ||
| return False | ||
|
|
||
| def get_by_category(self, category): | ||
| self.category = category | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's no need to set |
||
| category_list = [] | ||
| for item in self.inventory: | ||
| if item.category == category: | ||
| category_list.append(item) | ||
|
|
||
| return category_list | ||
|
|
||
| def swap_items(self, vendor, my_item, their_item): | ||
| if my_item not in self.inventory or their_item not in vendor.inventory: | ||
| return False | ||
|
|
||
| self.inventory.remove(my_item) | ||
| vendor.inventory.append(my_item) | ||
|
Comment on lines
+32
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These would've been good places to use your own |
||
|
|
||
| vendor.inventory.remove(their_item) | ||
| self.inventory.append(their_item) | ||
|
|
||
| return True | ||
|
|
||
| def swap_first_item(self, vendor): | ||
| if self.inventory == [] or vendor.inventory == []: | ||
| return False | ||
|
|
||
| vendor.inventory.append(self.inventory[0]) | ||
| self.inventory.remove(self.inventory[0]) | ||
|
|
||
| self.inventory.append(vendor.inventory[0]) | ||
| vendor.inventory.remove(vendor.inventory[0]) | ||
|
Comment on lines
+44
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Swapping items sounds a lot like what the |
||
|
|
||
| return True | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ | |
| import pytest | ||
| from swap_meet.vendor import Vendor | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_vendor_has_inventory(): | ||
| vendor = Vendor() | ||
| assert len(vendor.inventory) == 0 | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_vendor_takes_optional_inventory(): | ||
| inventory = ["a", "b", "c"] | ||
| vendor = Vendor(inventory=inventory) | ||
|
|
@@ -16,7 +16,7 @@ def test_vendor_takes_optional_inventory(): | |
| assert "b" in vendor.inventory | ||
| assert "c" in vendor.inventory | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_adding_to_inventory(): | ||
| vendor = Vendor() | ||
| item = "new item" | ||
|
|
@@ -27,7 +27,7 @@ def test_adding_to_inventory(): | |
| assert item in vendor.inventory | ||
| assert result == item | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_removing_from_inventory_returns_item(): | ||
| item = "item to remove" | ||
| vendor = Vendor( | ||
|
|
@@ -40,7 +40,7 @@ def test_removing_from_inventory_returns_item(): | |
| assert item not in vendor.inventory | ||
| assert result == item | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_removing_not_found_is_false(): | ||
| item = "item to remove" | ||
| vendor = Vendor( | ||
|
|
@@ -49,7 +49,7 @@ def test_removing_not_found_is_false(): | |
|
|
||
| result = vendor.remove(item) | ||
|
|
||
| raise Exception("Complete this test according to comments below.") | ||
| # ********************************************************************* | ||
| assert result == False | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would also be good to add an assert to make sure the length of the inventory didn't get changed. |
||
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ | |
| from swap_meet.vendor import Vendor | ||
| from swap_meet.item import Item | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_items_have_blank_default_category(): | ||
| item = Item() | ||
| assert item.category == "" | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_get_items_by_category(): | ||
| item_a = Item(category="clothing") | ||
| item_b = Item(category="electronics") | ||
|
|
@@ -23,7 +23,7 @@ def test_get_items_by_category(): | |
| assert item_c in items | ||
| assert item_b not in items | ||
|
|
||
| @pytest.mark.skip | ||
| #@pytest.mark.skip | ||
| def test_get_no_matching_items_by_category(): | ||
| item_a = Item(category="clothing") | ||
| item_b = Item(category="clothing") | ||
|
|
@@ -34,7 +34,7 @@ def test_get_no_matching_items_by_category(): | |
|
|
||
| items = vendor.get_by_category("electronics") | ||
|
|
||
| raise Exception("Complete this test according to comments below.") | ||
| assert len(items) == 0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start on using the Item super class here! However, this doesn't fully take advantage of what super classes can do! You don't need to story category or condition information here, you can pass that up to the Item class. None of the child classes need those lines of code, which will make the code cleaner.