Panthers_A18 - Lee Reyes and Sika Sarpong by sikasarpong · Pull Request #85 · Ada-C18/swap-meet

sikasarpong · 2022-10-07T07:25:27Z

No description provided.

… method to overide string

audreyandoy

Lee and Sika!

Your submission completed all waves and passed all required tests. Your code was easy to read and utilized a lot of helper functions which made your code very neat!

My main feedback primarily focuses on using the parent constructor and ways to refactor.

Overall, this project is well-deserving of a 🟢 green 🟢 ✨

Keep up the great work 🐈‍⬛ ✨

audreyandoy · 2022-10-26T19:10:28Z

swap_meet/clothing.py

+class Clothing(Item):
+    def __init__(self, category="Clothing", condition=0, age=0):
+        super().__init__(category, condition, age)
+
+    def __str__(self):
+        return "The finest clothing you could wear."
+


Setting a default value will still allow us to reassign the value. In this case, every Clothing instance can change its category to 'Electronics':

pants = Clothing('Electronics', 4.0) print(pants.category) # returns 'Electronics' #what are electronic pants? lol

We can move the default assignment of category to the parent super() constructor. This will ensure that every Clothing instance will be assigned 'Clothing' as its category.

pants = Clothing(4.0) print(pants.category) # returns clothing

audreyandoy · 2022-10-26T19:10:57Z

swap_meet/decor.py

+class Decor(Item):
+    def __init__(self, category="Decor", condition=0, age=0):
+        super().__init__(category, condition, age)
+
+    def __str__(self):
+        return "Something to decorate your space."


Same comment about category in the child class constructor can also be applied here.

audreyandoy · 2022-10-26T19:11:03Z

swap_meet/electronics.py

+class Electronics(Item):
+    def __init__(self, category="Electronics", condition=0, age=0):
+        super().__init__(category, condition, age)
+
+    def __str__(self):
+        return "A gadget full of buttons and secrets."


Same comment about category in the child class constructor can also be applied here.

audreyandoy · 2022-10-26T19:12:38Z

swap_meet/item.py

+    def condition_description(self):
+        if self.condition == 0:
+            return "Ew. You don't want that."
+        elif self.condition == 1:
+            return "Maybe you need gloves for that."
+        elif self.condition == 2:
+            return "Heavily Used"
+        elif self.condition == 3:
+            return "Decent"
+        elif self.condition == 4:
+            return "Lightly Used"
+        elif self.condition == 5:
+            return "Like new!"


🤣 lol Love the condition descriptions. "maybe you need gloves for that" is my fav.

audreyandoy · 2022-10-26T19:14:16Z

swap_meet/vendor.py

 class Vendor:
-    pass
+    def __init__(self, inventory=None) -> None:
+        self.inventory = inventory if inventory is not None else []


👍 Great work in handling default parameters for mutable types. It's unsafe to set [] as the default value, but we can use None to stand in for the value when not supplied by the caller, and then use a new empty list in its place.

audreyandoy · 2022-10-26T19:22:55Z