Open
Conversation
jbieniosek
reviewed
Oct 13, 2022
jbieniosek
left a comment
jbieniosek
left a comment
There was a problem hiding this comment.
Great work on this project Emma! The code is very clean and easy to read. Fantastic use of helper methods in the Vendor class! This project is green.
Comment on lines
+9
to
+21
| def condition_description(self): | ||
| if self.condition == 0: | ||
| return "Very Poor" | ||
| elif self.condition == 1: | ||
| return "Poor" | ||
| elif self.condition == 2: | ||
| return "Fair" | ||
| elif self.condition == 3: | ||
| return "Good" | ||
| elif self.condition == 4: | ||
| return "Very Good" | ||
| elif self.condition == 5.0: | ||
| return "Exceptional" |
There was a problem hiding this comment.
Conditions can be a float, but this function will only work for whole numbers. If an item has a condition of 3.5, this function will return None. How could you adapt these conditionals to work for floats?
Comment on lines
+39
to
+40
| self.add(friend.inventory.pop(0)) | ||
| friend.add(self.inventory.pop(0)) |
There was a problem hiding this comment.
Could you use swap_items to simplify the code here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.