-
Notifications
You must be signed in to change notification settings - Fork 110
Hang - Lions #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Hang - Lions #92
Changes from all commits
50ffdb7
9e69de0
c2df722
23751a6
04aa758
e58f39c
01ecb93
6b226eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,11 @@ | ||
| class Clothing: | ||
| pass | ||
| from swap_meet.item import Item | ||
| class Clothing(Item): | ||
| def __init__(self, condition = 0, category = "Clothing" ): | ||
| super().__init__(category, condition) | ||
|
|
||
|
|
||
| def __str__(self): | ||
| return "The finest clothing you could wear." | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,10 @@ | ||
| class Decor: | ||
| pass | ||
| from swap_meet.item import Item | ||
| class Decor(Item): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great! |
||
| def __init__(self, condition = 0, category = "Decor" ): | ||
| super().__init__(category, condition) | ||
|
|
||
|
|
||
| def __str__(self): | ||
| return "Something to decorate your space." | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,8 @@ | ||
| class Electronics: | ||
| pass | ||
| from swap_meet.item import Item | ||
| class Electronics(Item): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great! |
||
| def __init__(self, condition = 0, category = "Electronics" ): | ||
| super().__init__(category, condition) | ||
|
|
||
| def __str__(self): | ||
| return "A gadget full of buttons and secrets." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,26 @@ | ||
|
|
||
|
|
||
| class Item: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| pass | ||
| def __init__(self, category = "", condition = 0): | ||
| self.category = category | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): | ||
| return "Hello World!" | ||
|
|
||
| def condition_description(self): | ||
| if self.condition == 5: | ||
| return "The best you can get." | ||
| if self.condition == 4: | ||
| return "It's quality." | ||
| if self.condition == 3: | ||
| return "It's good enough." | ||
| if self.condition == 2: | ||
| return "Not sure on this one." | ||
| if self.condition == 1: | ||
| return "Another person's trash might be someone's treasure?" | ||
| if self.condition == 0: | ||
| return "I would just throw this out." | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,81 @@ | ||
| from swap_meet.item import Item | ||
| from swap_meet.clothing import Clothing | ||
| from swap_meet.decor import Decor | ||
| from swap_meet.electronics import Electronics | ||
|
Comment on lines
+1
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These imports actually aren't needed! It's good practice once you're done coding to go back and check to see if you accidentally imported things you don't need and remove them. |
||
|
|
||
| class Vendor: | ||
| pass | ||
| def __init__(self, inventory = None): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| if inventory is None: | ||
| inventory = [] | ||
| self.inventory = inventory | ||
|
|
||
|
|
||
| def add(self, item): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| self.inventory.append(item) | ||
| return item | ||
|
|
||
| def remove(self, item): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the instructions, this function should return |
||
| if item in self.inventory: | ||
| self.inventory.remove(item) | ||
| return item | ||
|
|
||
|
|
||
| def get_by_category(self, category): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| items = [] | ||
| for item in self.inventory: | ||
| if item.category == category: | ||
| items.append(item) | ||
| return items | ||
|
|
||
| def swap_items(self, another_vendor, my_item, their_item): | ||
| if my_item not in self.inventory or their_item not in another_vendor.inventory: | ||
| return False | ||
| else: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The else is not necessary! Since the if has a return statement, if we move past it, we know we're in the else. The other statements don't need to be nested under an else. |
||
| self.remove(my_item) | ||
| another_vendor.add(my_item) | ||
| another_vendor.remove(their_item) | ||
| return self.add(their_item) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function is supposed to return |
||
|
|
||
|
|
||
|
|
||
| def swap_first_item(self, another_vendor): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great! |
||
| if self.inventory == [] or another_vendor.inventory == []: | ||
| return False | ||
| else: | ||
| my_first_item = self.inventory[0] | ||
| their_first_item = another_vendor.inventory[0] | ||
| return self.swap_items(another_vendor, my_first_item, their_first_item) | ||
|
|
||
|
|
||
|
|
||
| def get_best_by_category(self, category): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great! |
||
|
|
||
| items_in_category = self.get_by_category(category) | ||
|
|
||
| if items_in_category == False: | ||
| return None | ||
| else: | ||
| best_item_so_far = None | ||
| for item in items_in_category: | ||
| if best_item_so_far is None or best_item_so_far.condition < item.condition: | ||
| best_item_so_far = item | ||
| return best_item_so_far | ||
|
|
||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent! |
||
| # my_priority= category vendor wants to receive | ||
| # their_priority=category other wants to receive | ||
|
|
||
| my_best_item_in_category =self.get_best_by_category(their_priority) | ||
| their_best_item_in_category = other.get_best_by_category(my_priority) | ||
| if my_best_item_in_category is None or their_best_item_in_category is None: | ||
| return False | ||
| return self.swap_items(other,my_best_item_in_category,their_best_item_in_category) | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,10 @@ | |
| from swap_meet.vendor import Vendor | ||
| from swap_meet.item import Item | ||
|
|
||
| @pytest.mark.skip | ||
| @pytest.mark.integration_test | ||
| # @pytest.mark.skip | ||
| # @pytest.mark.integration_test | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please do NOT remove this! Pytest needs to know that this is an integration test. Please only remove the skip above. |
||
| def test_integration_wave_01_02_03(): | ||
| # make a vendor | ||
|
|
||
| vendor = Vendor() | ||
| assert len(vendor.inventory) == 0 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ | |
| import pytest | ||
| from swap_meet.vendor import Vendor | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_vendor_has_inventory(): | ||
| vendor = Vendor() | ||
| assert len(vendor.inventory) == 0 | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_vendor_takes_optional_inventory(): | ||
| inventory = ["a", "b", "c"] | ||
| vendor = Vendor(inventory=inventory) | ||
|
|
@@ -16,7 +16,7 @@ def test_vendor_takes_optional_inventory(): | |
| assert "b" in vendor.inventory | ||
| assert "c" in vendor.inventory | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_adding_to_inventory(): | ||
| vendor = Vendor() | ||
| item = "new item" | ||
|
|
@@ -27,7 +27,7 @@ def test_adding_to_inventory(): | |
| assert item in vendor.inventory | ||
| assert result == item | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_removing_from_inventory_returns_item(): | ||
| item = "item to remove" | ||
| vendor = Vendor( | ||
|
|
@@ -40,7 +40,7 @@ def test_removing_from_inventory_returns_item(): | |
| assert item not in vendor.inventory | ||
| assert result == item | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_removing_not_found_is_false(): | ||
| item = "item to remove" | ||
| vendor = Vendor( | ||
|
|
@@ -49,7 +49,9 @@ def test_removing_not_found_is_false(): | |
|
|
||
| result = vendor.remove(item) | ||
|
|
||
| raise Exception("Complete this test according to comments below.") | ||
| # raise Exception("Complete this test according to comments below.") | ||
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
| assert not result | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great assert! It would also be a good idea to check to make sure the inventory length has not changed because something accidentally got removed. |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ | |
| from swap_meet.vendor import Vendor | ||
| from swap_meet.item import Item | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_items_have_blank_default_category(): | ||
| item = Item() | ||
| assert item.category == "" | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_get_items_by_category(): | ||
| item_a = Item(category="clothing") | ||
| item_b = Item(category="electronics") | ||
|
|
@@ -23,7 +23,7 @@ def test_get_items_by_category(): | |
| assert item_c in items | ||
| assert item_b not in items | ||
|
|
||
| @pytest.mark.skip | ||
| # @pytest.mark.skip | ||
| def test_get_no_matching_items_by_category(): | ||
| item_a = Item(category="clothing") | ||
| item_b = Item(category="clothing") | ||
|
|
@@ -34,7 +34,11 @@ def test_get_no_matching_items_by_category(): | |
|
|
||
| items = vendor.get_by_category("electronics") | ||
|
|
||
| raise Exception("Complete this test according to comments below.") | ||
| # raise Exception("Complete this test according to comments below.") | ||
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
| assert len(items) == 0 | ||
| assert item_a not in items | ||
| assert item_b not in items | ||
| assert item_c not in items | ||
|
Comment on lines
+42
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great job! These asserts are actually not needed. Since the items list is empty, you already know these individual items are not in there. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to remove category from the
__init__function. We don't want the user to be able to set the category. It should always be "Clothing" for the Clothing class. Instead, you can just add "Clothing" as the category when you call super.